mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fixed pass by reference and added spec

Browse source
This commit is contained in:
John Kleinschmidt 2017-03-08 22:06:26 -05:00
parent 950e3436c2
commit d5a658bbe4
3 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/api/atom_api_web_contents.cc
View file

@ -1067,13 +1067,13 @@ void WebContents::GoToOffset(int offset) {
web_contents()->GetController().GoToOffset(offset); web_contents()->GetController().GoToOffset(offset);
} }
const std::string& WebContents::GetWebRTCIPHandlingPolicy() const { const std::string WebContents::GetWebRTCIPHandlingPolicy() const {
return web_contents()-> return web_contents()->
GetMutableRendererPrefs()->webrtc_ip_handling_policy; GetMutableRendererPrefs()->webrtc_ip_handling_policy;
} }
void WebContents::SetWebRTCIPHandlingPolicy( void WebContents::SetWebRTCIPHandlingPolicy(
const std::string webrtc_ip_handling_policy) { const std::string& webrtc_ip_handling_policy) {
if (GetWebRTCIPHandlingPolicy() == webrtc_ip_handling_policy) if (GetWebRTCIPHandlingPolicy() == webrtc_ip_handling_policy)
return; return;
web_contents()->GetMutableRendererPrefs()->webrtc_ip_handling_policy = web_contents()->GetMutableRendererPrefs()->webrtc_ip_handling_policy =

4
atom/browser/api/atom_api_web_contents.h
View file

@ -92,8 +92,8 @@ class WebContents : public mate::TrackableObject<WebContents>,
void GoBack(); void GoBack();
void GoForward(); void GoForward();
void GoToOffset(int offset); void GoToOffset(int offset);
const std::string& GetWebRTCIPHandlingPolicy() const; const std::string GetWebRTCIPHandlingPolicy() const;
void SetWebRTCIPHandlingPolicy(const std::string webrtc_ip_handling_policy); void SetWebRTCIPHandlingPolicy(const std::string& webrtc_ip_handling_policy);
bool IsCrashed() const; bool IsCrashed() const;
void SetUserAgent(const std::string& user_agent, mate::Arguments* args); void SetUserAgent(const std::string& user_agent, mate::Arguments* args);
std::string GetUserAgent(); std::string GetUserAgent();

16
spec/api-web-contents-spec.js
View file

@ -527,4 +527,20 @@ describe('webContents module', function () {
w.loadURL(`file://${fixtures}/pages/c.html`) w.loadURL(`file://${fixtures}/pages/c.html`)
}) })
}) })
describe('webrtc ip policy api', () => {
it('can set and get webrtc ip policies', (done) => {
const policies = [
'default',
'default_public_interface_only',
'default_public_and_private_interfaces',
'disable_non_proxied_udp'
]
policies.forEach((policy) => {
w.webContents.setWebRTCIPHandlingPolicy(policy)
assert.equal(w.webContents.getWebRTCIPHandlingPolicy(), policy)
})
done()
})
})
}) })