feat: enable pdf viewer (#21794)

This commit is contained in:
Jeremy Apthorp 2020-02-12 16:39:12 -08:00 committed by GitHub
parent 85f9c779a8
commit d590f2efe3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
51 changed files with 1579 additions and 210 deletions

View file

@ -10,6 +10,7 @@
#include "base/containers/span.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/common/extensions/chrome_manifest_url_handlers.h"
#include "electron/buildflags/buildflags.h"
#include "electron/shell/common/extensions/api/generated_schemas.h"
#include "extensions/common/alias.h"
@ -23,45 +24,20 @@
#include "extensions/common/permissions/permissions_info.h"
#include "shell/common/extensions/api/api_features.h"
#include "shell/common/extensions/api/manifest_features.h"
#include "shell/common/extensions/api/permission_features.h"
namespace extensions {
namespace keys = manifest_keys;
namespace errors = manifest_errors;
// Parses the "devtools_page" manifest key.
class DevToolsPageHandler : public ManifestHandler {
public:
DevToolsPageHandler() = default;
~DevToolsPageHandler() override = default;
bool Parse(Extension* extension, base::string16* error) override {
std::unique_ptr<ManifestURL> manifest_url(new ManifestURL);
std::string devtools_str;
if (!extension->manifest()->GetString(keys::kDevToolsPage, &devtools_str)) {
*error = base::ASCIIToUTF16(errors::kInvalidDevToolsPage);
return false;
}
manifest_url->url_ = extension->GetResourceURL(devtools_str);
extension->SetManifestData(keys::kDevToolsPage, std::move(manifest_url));
PermissionsParser::AddAPIPermission(extension, APIPermission::kDevtools);
return true;
}
private:
base::span<const char* const> Keys() const override {
static constexpr const char* kKeys[] = {keys::kDevToolsPage};
return kKeys;
}
DISALLOW_COPY_AND_ASSIGN(DevToolsPageHandler);
};
constexpr APIPermissionInfo::InitInfo permissions_to_register[] = {
{APIPermission::kDevtools, "devtools",
APIPermissionInfo::kFlagImpliesFullURLAccess |
APIPermissionInfo::kFlagCannotBeOptional |
APIPermissionInfo::kFlagInternal},
{APIPermission::kResourcesPrivate, "resourcesPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
};
base::span<const APIPermissionInfo::InitInfo> GetPermissionInfos() {
return base::make_span(permissions_to_register);
@ -89,7 +65,7 @@ void ElectronExtensionsAPIProvider::AddManifestFeatures(
void ElectronExtensionsAPIProvider::AddPermissionFeatures(
extensions::FeatureProvider* provider) {
// No shell-specific permission features.
extensions::AddElectronPermissionFeatures(provider);
}
void ElectronExtensionsAPIProvider::AddBehaviorFeatures(