mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove unused WrappableBase::AfterInit() (#42986)

Browse source 
last caller removed in 6159066c (#22916)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-07-22 15:52:56 +02:00 • committed by GitHub
parent e259dd591f
commit d53f1d8ff4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/gin_helper/wrappable.cc
View file

@ -56,8 +56,6 @@ void WrappableBase::InitWith(v8::Isolate* isolate,
v8::Local<v8::Function> init; v8::Local<v8::Function> init;
if (Dictionary(isolate, wrapper).Get("_init", &init)) if (Dictionary(isolate, wrapper).Get("_init", &init))
init->Call(isolate->GetCurrentContext(), wrapper, 0, nullptr).IsEmpty(); init->Call(isolate->GetCurrentContext(), wrapper, 0, nullptr).IsEmpty();
AfterInit(isolate);
} }
// static // static

3
shell/common/gin_helper/wrappable_base.h
View file

@ -45,9 +45,6 @@ class WrappableBase {
v8::Isolate* isolate() const { return isolate_; } v8::Isolate* isolate() const { return isolate_; }
protected: protected:
// Called after the "_init" method gets called in JavaScript.
virtual void AfterInit(v8::Isolate* isolate) {}
// Bind the C++ class to the JS wrapper. // Bind the C++ class to the JS wrapper.
// This method should only be called by classes using Constructor. // This method should only be called by classes using Constructor.
virtual void InitWith(v8::Isolate* isolate, v8::Local<v8::Object> wrapper); virtual void InitWith(v8::Isolate* isolate, v8::Local<v8::Object> wrapper);