refactor: use std::map::try_emplace()
over std::map::insert()
(#46794)
refactor: prefer std::map::try_emplace() over std::map::insert() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
parent
5dab95335b
commit
d52670c749
10 changed files with 15 additions and 21 deletions
|
@ -103,10 +103,8 @@ void UsbChooserContext::InitDeviceList(
|
|||
std::vector<device::mojom::UsbDeviceInfoPtr> devices) {
|
||||
for (auto& device_info : devices) {
|
||||
DCHECK(device_info);
|
||||
if (ShouldExposeDevice(*device_info)) {
|
||||
devices_.insert(
|
||||
std::make_pair(device_info->guid, std::move(device_info)));
|
||||
}
|
||||
if (ShouldExposeDevice(*device_info))
|
||||
devices_.try_emplace(device_info->guid, std::move(device_info));
|
||||
}
|
||||
is_initialized_ = true;
|
||||
|
||||
|
@ -285,7 +283,7 @@ void UsbChooserContext::OnDeviceAdded(
|
|||
DCHECK(!devices_.contains(device_info->guid));
|
||||
if (!ShouldExposeDevice(*device_info))
|
||||
return;
|
||||
devices_.insert(std::make_pair(device_info->guid, device_info->Clone()));
|
||||
devices_.try_emplace(device_info->guid, device_info->Clone());
|
||||
|
||||
// Notify all observers.
|
||||
for (auto& observer : device_observer_list_)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue