mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: improve logging on http errors during release process (#43760)

Browse source 
* build: improve logging on http errors during release process (#43756)

Co-authored-by: Samuel Attard <sam@electronjs.org>

* build: improve logging on http errors during release process (again) (#43757)

Co-authored-by: Samuel Attard <sam@electronjs.org>

* build: improve logging on http errors during release process (again, but more) (#43758)

Co-authored-by: Samuel Attard <sam@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
This commit is contained in:
trop[bot] 2024-09-17 20:05:56 -07:00 • committed by GitHub
parent c5e1a336f2
commit d519913bfa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 37 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
script/release/release.js
View file

@ -393,9 +393,15 @@ async function verifyDraftGitHubReleaseAssets (release) {
const response = await got(url, {
followRedirect: false,
method: 'HEAD',
headers
headers,
throwHttpErrors: false
});
if (response.statusCode !== 302 && response.statusCode !== 301) {
console.error('Failed to HEAD github asset: ' + url);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.statusCode);
}
return { url: response.headers.location, file: asset.name };
})).catch(err => {
console.error(`${fail} Error downloading files from GitHub`, err);
@ -406,7 +412,16 @@ async function verifyDraftGitHubReleaseAssets (release) {
}
async function getShaSumMappingFromUrl (shaSumFileUrl, fileNamePrefix) {
const response = await got(shaSumFileUrl);
const response = await got(shaSumFileUrl, {
throwHttpErrors: false
});
if (response.statusCode !== 200) {
console.error('Failed to fetch SHASUM mapping: ' + shaSumFileUrl);
console.error('Bad SHASUM mapping response: ' + response.body.trim());
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.statusCode);
}
const raw = response.body;
return raw.split('\n').map(line => line.trim()).filter(Boolean).reduce((map, line) => {
const [sha, file] = line.replace(' ', ' ').split(' ');