mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Upgrade cpplint

Browse source
This commit is contained in:
Cheng Zhao 2014-12-15 17:15:56 -08:00
parent 1641caf353
commit d50eeb04d5
6 changed files with 23 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_web_contents.h
View file

@ -92,7 +92,7 @@ class WebContents : public mate::EventEmitter,
~WebContents(); ~WebContents();
// mate::Wrappable: // mate::Wrappable:
virtual mate::ObjectTemplateBuilder GetObjectTemplateBuilder( mate::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override; v8::Isolate* isolate) override;
// content::WebContentsDelegate: // content::WebContentsDelegate:

4
atom/browser/atom_browser_context.h
View file

@ -23,12 +23,12 @@ class AtomBrowserContext : public brightray::BrowserContext {
static AtomBrowserContext* Get(); static AtomBrowserContext* Get();
// brightray::URLRequestContextGetter::Delegate: // brightray::URLRequestContextGetter::Delegate:
virtual net::URLRequestJobFactory* CreateURLRequestJobFactory( net::URLRequestJobFactory* CreateURLRequestJobFactory(
content::ProtocolHandlerMap* handlers, content::ProtocolHandlerMap* handlers,
content::URLRequestInterceptorScopedVector* interceptors) override; content::URLRequestInterceptorScopedVector* interceptors) override;
// content::BrowserContext: // content::BrowserContext:
virtual content::BrowserPluginGuestManager* GetGuestManager() override; content::BrowserPluginGuestManager* GetGuestManager() override;
AtomURLRequestJobFactory* job_factory() const { return job_factory_; } AtomURLRequestJobFactory* job_factory() const { return job_factory_; }

32
atom/browser/atom_speech_recognition_manager_delegate.h
View file

@ -20,28 +20,28 @@ class AtomSpeechRecognitionManagerDelegate
virtual ~AtomSpeechRecognitionManagerDelegate(); virtual ~AtomSpeechRecognitionManagerDelegate();
// content::SpeechRecognitionEventListener: // content::SpeechRecognitionEventListener:
virtual void OnRecognitionStart(int session_id) override; void OnRecognitionStart(int session_id) override;
virtual void OnAudioStart(int session_id) override; void OnAudioStart(int session_id) override;
virtual void OnEnvironmentEstimationComplete(int session_id) override; void OnEnvironmentEstimationComplete(int session_id) override;
virtual void OnSoundStart(int session_id) override; void OnSoundStart(int session_id) override;
virtual void OnSoundEnd(int session_id) override; void OnSoundEnd(int session_id) override;
virtual void OnAudioEnd(int session_id) override; void OnAudioEnd(int session_id) override;
virtual void OnRecognitionEnd(int session_id) override; void OnRecognitionEnd(int session_id) override;
virtual void OnRecognitionResults( void OnRecognitionResults(
int session_id, const content::SpeechRecognitionResults& result) override; int session_id, const content::SpeechRecognitionResults& result) override;
virtual void OnRecognitionError( void OnRecognitionError(
int session_id, const content::SpeechRecognitionError& error) override; int session_id, const content::SpeechRecognitionError& error) override;
virtual void OnAudioLevelsChange(int session_id, float volume, void OnAudioLevelsChange(int session_id, float volume,
float noise_volume) override; float noise_volume) override;
// content::SpeechRecognitionManagerDelegate: // content::SpeechRecognitionManagerDelegate:
virtual void GetDiagnosticInformation(bool* can_report_metrics, void GetDiagnosticInformation(bool* can_report_metrics,
std::string* hardware_info) override; std::string* hardware_info) override;
virtual void CheckRecognitionIsAllowed( void CheckRecognitionIsAllowed(
int session_id, int session_id,
base::Callback<void(bool ask_user, bool is_allowed)> callback) override; base::Callback<void(bool ask_user, bool is_allowed)> callback) override;
virtual content::SpeechRecognitionEventListener* GetEventListener() override; content::SpeechRecognitionEventListener* GetEventListener() override;
virtual bool FilterProfanities(int render_process_id) override; bool FilterProfanities(int render_process_id) override;
private: private:
DISALLOW_COPY_AND_ASSIGN(AtomSpeechRecognitionManagerDelegate); DISALLOW_COPY_AND_ASSIGN(AtomSpeechRecognitionManagerDelegate);

3
atom/browser/native_window.cc
View file

@ -439,9 +439,10 @@ void NativeWindow::OverrideWebkitPrefs(const GURL& url,
prefs->experimental_webgl_enabled = b; prefs->experimental_webgl_enabled = b;
if (web_preferences_.Get("webaudio", &b)) if (web_preferences_.Get("webaudio", &b))
prefs->webaudio_enabled = b; prefs->webaudio_enabled = b;
if (web_preferences_.Get("extra-plugin-dirs", &list)) if (web_preferences_.Get("extra-plugin-dirs", &list)) {
for (size_t i = 0; i < list.size(); ++i) for (size_t i = 0; i < list.size(); ++i)
content::PluginService::GetInstance()->AddExtraPluginDir(list[i]); content::PluginService::GetInstance()->AddExtraPluginDir(list[i]);
}
} }
void NativeWindow::NotifyWindowClosed() { void NativeWindow::NotifyWindowClosed() {

2
atom/common/crash_reporter/win/crash_service.cc
View file

@ -456,7 +456,7 @@ DWORD CrashService::AsyncSendDump(void* context) {
default: default:
report_id = L"<unknown>"; report_id = L"<unknown>";
break; break;
}; }
} }
VLOG(1) << "dump for pid =" << info->pid << " crash2 id =" << report_id; VLOG(1) << "dump for pid =" << info->pid << " crash2 id =" << report_id;

2
vendor/depot_tools vendored

@ -1 +1 @@
Subproject commit a738935a12e7ef428b3a852f1f3eca6bbfa0182b Subproject commit 4fa73b8ca6899bc69577932b80145a6bf07e4424