From d4d1230107a899f3f458b581e4d4b6cae19dd79e Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Fri, 26 Apr 2013 21:28:41 +0800 Subject: [PATCH] Should wrap WeakCallback with handle scope. --- common/api/atom_api_id_weak_map.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/api/atom_api_id_weak_map.cc b/common/api/atom_api_id_weak_map.cc index 1680024d46ef..3b4d975fadcc 100644 --- a/common/api/atom_api_id_weak_map.cc +++ b/common/api/atom_api_id_weak_map.cc @@ -42,6 +42,8 @@ int IDWeakMap::GetNextID() { void IDWeakMap::WeakCallback(v8::Isolate* isolate, v8::Persistent value, void *data) { + v8::HandleScope scope; + IDWeakMap* obj = static_cast(data); int key = value->ToObject()->GetHiddenValue( v8::String::New("IDWeakMapKey"))->IntegerValue();