mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: ensure /dev/null fd is closed on failure (#47541)

Browse source 
* fix: ensure /dev/null fd is closed on failure

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: ignore closehandle for windows

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
This commit is contained in:
trop[bot] 2025-06-24 14:22:56 -04:00 • committed by GitHub
commit d4a93c896d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/browser/api/electron_api_utility_process.cc
View file

@ -78,6 +78,9 @@ UtilityProcessWrapper::UtilityProcessWrapper(
base::FileHandleMappingVector fds_to_remap; base::FileHandleMappingVector fds_to_remap;
#endif #endif
for (const auto& [io_handle, io_type] : stdio) { for (const auto& [io_handle, io_type] : stdio) {
if (io_handle == IOHandle::STDIN)
continue;
if (io_type == IOType::IO_PIPE) { if (io_type == IOType::IO_PIPE) {
#if BUILDFLAG(IS_WIN) #if BUILDFLAG(IS_WIN)
HANDLE read = nullptr; HANDLE read = nullptr;