mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: make FILEVERSION 4th component 0 on nightly builds (#15074)

Browse source 
Fixes #14900
This commit is contained in:
Samuel Attard 2018-10-12 00:11:20 +11:00 committed by John Kleinschmidt
parent 99f5f17a8d
commit d46834265f
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
script/bump-version.py
View file

@ -97,7 +97,7 @@ def main():
with scoped_cwd(SOURCE_ROOT):
update_version(version, suffix)
update_win_rc(version, versions)
update_win_rc(version, versions, args.bump == "nightly")
update_version_h(versions, suffix)
update_info_plist(version)
update_package_json(version, suffix)
@ -120,7 +120,7 @@ def update_version(version, suffix):
f.write(version + suffix)
def update_win_rc(version, versions):
def update_win_rc(version, versions, is_nightly_version):
pattern_fv = re.compile(' FILEVERSION [0-9,]+')
pattern_pv = re.compile(' PRODUCTVERSION [0-9,]+')
pattern_fvs = re.compile(' *VALUE "FileVersion", "[0-9.]+"')
@ -134,7 +134,10 @@ def update_win_rc(version, versions):
for i in range(0, len(lines)):
line = lines[i]
if pattern_fv.match(line):
lines[i] = ' FILEVERSION {0}\r\n'.format(','.join(versions))
versions_64_bit = versions[::]
if is_nightly_version:
versions_64_bit[3] = '0'
lines[i] = ' FILEVERSION {0}\r\n'.format(','.join(versions_64_bit))
elif pattern_pv.match(line):
lines[i] = ' PRODUCTVERSION {0}\r\n'.format(','.join(versions))
elif pattern_fvs.match(line):