From 0b3b508eca7a30293a81702896506afc42f9c252 Mon Sep 17 00:00:00 2001
From: John Kleinschmidt <jkleinsc@github.com>
Date: Mon, 17 Sep 2018 14:53:18 -0400
Subject: [PATCH] ci: Skip VSTS testing builds on older branches

Also, don't send slack notifications for actual releases
---
 vsts.yml | 77 +++++++++-----------------------------------------------
 1 file changed, 12 insertions(+), 65 deletions(-)

diff --git a/vsts.yml b/vsts.yml
index 72418c7baa6..b19286d8401 100644
--- a/vsts.yml
+++ b/vsts.yml
@@ -2,29 +2,21 @@ resources:
 - repo: self
 steps:
 - bash: |
-    if [ "$ELECTRON_RELEASE" == "1" ]; then
-      echo 'Bootstrapping Electron for release build'
-      script/bootstrap.py --target_arch=$TARGET_ARCH
-    else
-      echo 'Bootstrapping Electron for debug build'
-      script/bootstrap.py --target_arch=$TARGET_ARCH --dev
-    fi
+    echo 'Non release VSTS builds do not run on older branches'
+  displayName: Skip build on older branch
+  condition: ne(variables['ELECTRON_RELEASE'], '1')
+
+- bash: |
+    echo 'Bootstrapping Electron for release build'
+    script/bootstrap.py --target_arch=$TARGET_ARCH
   name: Bootstrap
+  condition: eq(variables['ELECTRON_RELEASE'], '1')
 
 - bash: |
-    npm run lint
-  name: Lint
-  condition: and(succeeded(), ne(variables['ELECTRON_RELEASE'], '1'))
-
-- bash: |
-    if [ "$ELECTRON_RELEASE" == "1" ]; then
-      echo 'Building Electron for release'
-      script/build.py -c R
-    else
-      echo 'Building Electron for debug'
-      script/build.py -c D
-    fi
+    echo 'Building Electron for release'
+    script/build.py -c R
   name: Build
+  condition: and(succeeded(), eq(variables['ELECTRON_RELEASE'], '1'))
 
 - bash: |
     echo 'Creating Electron release distribution'
@@ -43,56 +35,11 @@ steps:
   name: Upload_distribution
   condition: and(succeeded(), eq(variables['ELECTRON_RELEASE'], '1'))
 
-- bash: |
-    echo 'Testing Electron build'
-    mkdir junit
-    export MOCHA_FILE="junit/test-results.xml"
-    export MOCHA_REPORTER="mocha-junit-reporter"
-    if [ "$ELECTRON_RELEASE" == "1" ]; then
-      script/test.py --ci --rebuild_native_modules -c R
-    else
-      script/test.py --ci --rebuild_native_modules
-    fi
-  name: Test
-  condition: or(ne(variables['ELECTRON_RELEASE'], '1'), eq(variables['UPLOAD_TO_S3'], '1'))
-
-- bash: |
-    echo 'Verifying ffmpeg on build'
-    if [ "$ELECTRON_RELEASE" == "1" ]; then
-      script/verify-ffmpeg.py -R
-    else
-      script/verify-ffmpeg.py
-    fi
-  name: Verify_FFmpeg
-  condition: or(ne(variables['ELECTRON_RELEASE'], '1'), eq(variables['UPLOAD_TO_S3'], '1'))
-
-- task: PublishTestResults@2
-  displayName: Publish Test Results
-  inputs:
-    testResultsFiles: 'test-results.xml'
-    searchFolder: junit
-  condition: and(always(), ne(variables['ELECTRON_RELEASE'], '1'))
-
-- bash: |
-    export BUILD_URL="${SYSTEM_TEAMFOUNDATIONCOLLECTIONURI}${SYSTEM_TEAMPROJECT}/_build/results?buildId=${BUILD_BUILDID}"
-    export MESSAGE="Build failed for *<$BUILD_URL|$BUILD_DEFINITIONNAME>* nightly build."
-    curl -g -H "Content-Type: application/json" -X POST \
-    -d "{\"text\": \"$MESSAGE\", \"attachments\": [{\"color\": \"#FC5C3C\",\"title\": \"$BUILD_DEFINITIONNAME nightly build results\",\"title_link\": \"$BUILD_URL\"}]}" $(slack_webhook)
-  name: Post_Slack_Notification_on_Failure
-  condition: failed()
-
-- bash: |
-    export BUILD_URL="${SYSTEM_TEAMFOUNDATIONCOLLECTIONURI}${SYSTEM_TEAMPROJECT}/_build/results?buildId=${BUILD_BUILDID}"
-    export MESSAGE="Build succeeded for *<$BUILD_URL|$BUILD_DEFINITIONNAME>* nightly build."
-    curl -g -H "Content-Type: application/json" -X POST \
-    -d "{\"text\": \"$MESSAGE\", \"attachments\": [{\"color\": \"#FC5C3C\",\"title\": \"$BUILD_DEFINITIONNAME nightly build results\",\"title_link\": \"$BUILD_URL\"}]}" $(slack_webhook)
-  name: Post_Slack_Notification_on_Success
-  condition: succeeded()
-
 - task: PublishBuildArtifacts@1
   displayName: Publish Build Artifacts
   inputs:
     PathtoPublish: '$(Build.SourcesDirectory)/out'
     ArtifactName: out
+  condition: and(succeeded(), eq(variables['ELECTRON_RELEASE'], '1'))
 
 - task: mspremier.PostBuildCleanup.PostBuildCleanup-task.PostBuildCleanup@3