feat: add webPreferences.enableRemoteModule option (#13028)

lib/sandboxed_renderer/api/exports/child_process.js

@@ -1,3 +1,4 @@
 'use strict'
 
-module.exports = require('electron').remote.require('child_process')
+const { getRemoteForUsage } = require('@electron/internal/renderer/remote')
+module.exports = getRemoteForUsage('child_process').require('child_process')

lib/sandboxed_renderer/api/exports/electron.js

@@ -6,6 +6,7 @@ for (const {
   name,
   load,
   enabled = true,
+  configurable = false,
   private: isPrivate = false
 } of moduleList) {
   if (!enabled) {
@@ -13,6 +14,7 @@ for (const {
   }
 
   Object.defineProperty(exports, name, {
+    configurable,
     enumerable: !isPrivate,
     get: load
   })

lib/sandboxed_renderer/api/exports/fs.js

@@ -1,3 +1,4 @@
 'use strict'
 
-module.exports = require('electron').remote.require('fs')
+const { getRemoteForUsage } = require('@electron/internal/renderer/remote')
+module.exports = getRemoteForUsage('fs').require('fs')

lib/sandboxed_renderer/api/exports/os.js

@@ -1,3 +1,4 @@
 'use strict'
 
-module.exports = require('electron').remote.require('os')
+const { getRemoteForUsage } = require('@electron/internal/renderer/remote')
+module.exports = getRemoteForUsage('os').require('os')

lib/sandboxed_renderer/api/exports/path.js

@@ -1,3 +1,4 @@
 'use strict'
 
-module.exports = require('electron').remote.require('path')
+const { getRemoteForUsage } = require('@electron/internal/renderer/remote')
+module.exports = getRemoteForUsage('path').require('path')

lib/sandboxed_renderer/api/module-list.js

@@ -16,21 +16,28 @@ module.exports = [
     name: 'ipcRenderer',
     load: () => require('@electron/internal/renderer/api/ipc-renderer')
   },
-  {
-    name: 'isPromise',
-    load: () => require('@electron/internal/common/api/is-promise'),
-    private: true
-  },
   {
     name: 'nativeImage',
     load: () => require('@electron/internal/common/api/native-image')
   },
   {
     name: 'remote',
+    configurable: true, // will be configured in init.js
     load: () => require('@electron/internal/renderer/api/remote')
   },
   {
     name: 'webFrame',
     load: () => require('@electron/internal/renderer/api/web-frame')
+  },
+  // The internal modules, invisible unless you know their names.
+  {
+    name: 'deprecate',
+    load: () => require('@electron/internal/common/api/deprecate'),
+    private: true
+  },
+  {
+    name: 'isPromise',
+    load: () => require('@electron/internal/common/api/is-promise'),
+    private: true
   }
 ]

lib/sandboxed_renderer/init.js

@@ -63,9 +63,21 @@ ipcNative.onExit = function () {
 }
 
 const {
-  preloadSrc, preloadError, process: processProps
+  preloadSrc, preloadError, isRemoteModuleEnabled, process: processProps
 } = ipcRenderer.sendSync('ELECTRON_BROWSER_SANDBOX_LOAD')
 
+const makePropertyNonConfigurable = function (object, name) {
+  const descriptor = Object.getOwnPropertyDescriptor(electron, name)
+  descriptor.configurable = false
+  Object.defineProperty(electron, name, descriptor)
+}
+
+if (isRemoteModuleEnabled) {
+  makePropertyNonConfigurable(electron, 'remote')
+} else {
+  delete electron.remote
+}
+
 require('@electron/internal/renderer/web-frame-init')()
 
 // Pass different process object to the preload script(which should not have