mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: convert shell.openItem to async shell.openPath (#20682)

Browse source
This commit is contained in:
Shelley Vohr 2019-11-07 23:08:43 -08:00 • committed by GitHub
parent fd70ac1173
commit d3622f9c37
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 121 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/common/platform_util.h
View file

@ -19,7 +19,7 @@ class GURL;
namespace platform_util {
typedef base::OnceCallback<void(const std::string&)> OpenExternalCallback;
typedef base::OnceCallback<void(const std::string&)> OpenCallback;
// Show the given file in a file manager. If possible, select the file.
// Must be called from the UI thread.
@ -27,7 +27,7 @@ void ShowItemInFolder(const base::FilePath& full_path);
// Open the given file in the desktop's default manner.
// Must be called from the UI thread.
bool OpenItem(const base::FilePath& full_path);
void OpenPath(const base::FilePath& full_path, OpenCallback callback);
struct OpenExternalOptions {
bool activate = true;
@ -38,7 +38,7 @@ struct OpenExternalOptions {
// (For example, mailto: URLs in the default mail user agent.)
void OpenExternal(const GURL& url,
const OpenExternalOptions& options,
OpenExternalCallback callback);
OpenCallback callback);
// Move a file to trash.
bool MoveItemToTrash(const base::FilePath& full_path, bool delete_on_fail);