mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove C-style void arg type for no-arg functions (#43919)

Browse source 
A small cleanup to remove use of the C-style function declaration idiom.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-09-24 00:36:20 -07:00 • committed by GitHub
parent ff65b58e2c
commit d35b848f95
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/osr/osr_render_widget_host_view.h
View file

@ -87,17 +87,17 @@ class OffScreenRenderWidgetHostView
void InitAsChild(gfx::NativeView) override; void InitAsChild(gfx::NativeView) override;
void SetSize(const gfx::Size&) override; void SetSize(const gfx::Size&) override;
void SetBounds(const gfx::Rect&) override; void SetBounds(const gfx::Rect&) override;
gfx::NativeView GetNativeView(void) override; gfx::NativeView GetNativeView() override;
gfx::NativeViewAccessible GetNativeViewAccessible(void) override; gfx::NativeViewAccessible GetNativeViewAccessible() override;
ui::TextInputClient* GetTextInputClient() override; ui::TextInputClient* GetTextInputClient() override;
void Focus() override {} void Focus() override {}
bool HasFocus() override; bool HasFocus() override;
uint32_t GetCaptureSequenceNumber() const override; uint32_t GetCaptureSequenceNumber() const override;
bool IsSurfaceAvailableForCopy(void) override; bool IsSurfaceAvailableForCopy() override;
void Hide(void) override; void Hide() override;
bool IsShowing(void) override; bool IsShowing() override;
void EnsureSurfaceSynchronizedForWebTest() override; void EnsureSurfaceSynchronizedForWebTest() override;
gfx::Rect GetViewBounds(void) override; gfx::Rect GetViewBounds() override;
gfx::Size GetVisibleViewportSize() override; gfx::Size GetVisibleViewportSize() override;
void SetInsets(const gfx::Insets&) override {} void SetInsets(const gfx::Insets&) override {}
void SetBackgroundColor(SkColor color) override; void SetBackgroundColor(SkColor color) override;
@ -107,7 +107,7 @@ class OffScreenRenderWidgetHostView
bool request_unadjusted_movement) override; bool request_unadjusted_movement) override;
blink::mojom::PointerLockResult ChangePointerLock( blink::mojom::PointerLockResult ChangePointerLock(
bool request_unadjusted_movement) override; bool request_unadjusted_movement) override;
void UnlockPointer(void) override {} void UnlockPointer() override {}
void TakeFallbackContentFrom(content::RenderWidgetHostView* view) override; void TakeFallbackContentFrom(content::RenderWidgetHostView* view) override;
#if BUILDFLAG(IS_MAC) #if BUILDFLAG(IS_MAC)
void SetActive(bool active) override {} void SetActive(bool active) override {}
@ -135,10 +135,10 @@ class OffScreenRenderWidgetHostView
void SetIsLoading(bool is_loading) override {} void SetIsLoading(bool is_loading) override {}
void TextInputStateChanged(const ui::mojom::TextInputState& params) override { void TextInputStateChanged(const ui::mojom::TextInputState& params) override {
} }
void ImeCancelComposition(void) override {} void ImeCancelComposition() override {}
void RenderProcessGone() override; void RenderProcessGone() override;
void ShowWithVisibility(content::PageVisibilityState page_visibility) final; void ShowWithVisibility(content::PageVisibilityState page_visibility) final;
void Destroy(void) override; void Destroy() override;
void UpdateTooltipUnderCursor(const std::u16string&) override {} void UpdateTooltipUnderCursor(const std::u16string&) override {}
input::CursorManager* GetCursorManager() override; input::CursorManager* GetCursorManager() override;
void CopyFromSurface( void CopyFromSurface(
@ -147,7 +147,7 @@ class OffScreenRenderWidgetHostView
base::OnceCallback<void(const SkBitmap&)> callback) override; base::OnceCallback<void(const SkBitmap&)> callback) override;
display::ScreenInfo GetScreenInfo() const override; display::ScreenInfo GetScreenInfo() const override;
void TransformPointToRootSurface(gfx::PointF* point) override {} void TransformPointToRootSurface(gfx::PointF* point) override {}
gfx::Rect GetBoundsInRootWindow(void) override; gfx::Rect GetBoundsInRootWindow() override;
std::optional<content::DisplayFeature> GetDisplayFeature() override; std::optional<content::DisplayFeature> GetDisplayFeature() override;
void SetDisplayFeatureForTesting( void SetDisplayFeatureForTesting(
const content::DisplayFeature* display_feature) override {} const content::DisplayFeature* display_feature) override {}

12
shell/common/platform_util_win.cc
View file

@ -47,11 +47,11 @@ class DeleteFileProgressSink : public IFileOperationProgressSink {
private: private:
// IFileOperationProgressSink // IFileOperationProgressSink
ULONG STDMETHODCALLTYPE AddRef(void) override; ULONG STDMETHODCALLTYPE AddRef() override;
ULONG STDMETHODCALLTYPE Release(void) override; ULONG STDMETHODCALLTYPE Release() override;
HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid, HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid,
LPVOID* ppvObj) override; LPVOID* ppvObj) override;
HRESULT STDMETHODCALLTYPE StartOperations(void) override; HRESULT STDMETHODCALLTYPE StartOperations() override;
HRESULT STDMETHODCALLTYPE FinishOperations(HRESULT) override; HRESULT STDMETHODCALLTYPE FinishOperations(HRESULT) override;
HRESULT STDMETHODCALLTYPE PreRenameItem(DWORD, IShellItem*, LPCWSTR) override; HRESULT STDMETHODCALLTYPE PreRenameItem(DWORD, IShellItem*, LPCWSTR) override;
HRESULT STDMETHODCALLTYPE HRESULT STDMETHODCALLTYPE
@ -90,9 +90,9 @@ class DeleteFileProgressSink : public IFileOperationProgressSink {
HRESULT, HRESULT,
IShellItem*) override; IShellItem*) override;
HRESULT STDMETHODCALLTYPE UpdateProgress(UINT, UINT) override; HRESULT STDMETHODCALLTYPE UpdateProgress(UINT, UINT) override;
HRESULT STDMETHODCALLTYPE ResetTimer(void) override; HRESULT STDMETHODCALLTYPE ResetTimer() override;
HRESULT STDMETHODCALLTYPE PauseTimer(void) override; HRESULT STDMETHODCALLTYPE PauseTimer() override;
HRESULT STDMETHODCALLTYPE ResumeTimer(void) override; HRESULT STDMETHODCALLTYPE ResumeTimer() override;
ULONG m_cRef; ULONG m_cRef;
}; };