From d1c302800f9268852cbceaea104f4ad02f881d5a Mon Sep 17 00:00:00 2001 From: Daniel Pham Date: Wed, 25 May 2016 19:25:51 -0400 Subject: [PATCH] Fix: Properly notify observers when window prevents close --- atom/browser/native_window_mac.mm | 6 ++++++ atom/browser/native_window_views.cc | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index cc31d308d144..d7f2350e4b04 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -6,6 +6,7 @@ #include +#include "atom/browser/window_list.h" #include "atom/common/color_util.h" #include "atom/common/draggable_region.h" #include "atom/common/options_switches.h" @@ -553,6 +554,11 @@ NativeWindowMac::~NativeWindowMac() { } void NativeWindowMac::Close() { + if (!IsClosable()) { + WindowList::WindowCloseCancelled(this); + return; + } + [window_ performClose:nil]; } diff --git a/atom/browser/native_window_views.cc b/atom/browser/native_window_views.cc index 82c1158bdcf1..21bff6388a66 100644 --- a/atom/browser/native_window_views.cc +++ b/atom/browser/native_window_views.cc @@ -9,6 +9,7 @@ #include "atom/browser/ui/views/menu_bar.h" #include "atom/browser/ui/views/menu_layout.h" +#include "atom/browser/window_list.h" #include "atom/common/color_util.h" #include "atom/common/draggable_region.h" #include "atom/common/native_mate_converters/image_converter.h" @@ -284,6 +285,11 @@ NativeWindowViews::~NativeWindowViews() { } void NativeWindowViews::Close() { + if (!IsClosable()) { + WindowList::WindowCloseCancelled(this); + return; + } + window_->Close(); }