diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index bad3b80a9b5c..628829f24deb 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -858,6 +858,18 @@ describe('browser-window module', function () { w.loadURL('about:blank') }) + it('throws errors for missing manifest.json files', function () { + assert.throws(function () { + BrowserWindow.addDevToolsExtension(path.join(__dirname, 'does-not-exist')) + }, /ENOENT: no such file or directory/) + }) + + it('throws errors for invalid manifest.json files', function () { + assert.throws(function () { + BrowserWindow.addDevToolsExtension(path.join(__dirname, 'fixtures', 'devtools-extensions', 'bad-manifest')) + }, /Unexpected token }/) + }) + describe('when the devtools is docked', function () { it('creates the extension', function (done) { w.webContents.openDevTools({mode: 'bottom'}) diff --git a/spec/fixtures/devtools-extensions/bad-manifest/manifest.json b/spec/fixtures/devtools-extensions/bad-manifest/manifest.json new file mode 100644 index 000000000000..5c34318c2147 --- /dev/null +++ b/spec/fixtures/devtools-extensions/bad-manifest/manifest.json @@ -0,0 +1 @@ +}