mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Erase window from weak map immediately after it's destroyed.

Browse source 
Otherwise it could happend that developers accessed the window after
it's destroyed but before it's GCed.
This commit is contained in:
Cheng Zhao 2013-05-20 14:55:46 +08:00
parent ca1b8ada99
commit d19e62d867
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
browser/atom/objects_registry.coffee
View file

@ -55,7 +55,10 @@ process.on 'ATOM_BROWSER_INTERNAL_NEW', (obj) ->
objectsWeakMap.add obj objectsWeakMap.add obj
# Also remember all windows. # Also remember all windows.
windowsWeakMap.add obj if obj.constructor is BrowserWindow if obj.constructor is BrowserWindow
id = windowsWeakMap.add obj
obj.on 'destroyed', ->
windowsWeakMap.remove id
exports.add = (processId, routingId, obj) -> exports.add = (processId, routingId, obj) ->
# Some native objects may already been added to objectsWeakMap, be care not # Some native objects may already been added to objectsWeakMap, be care not