From d15d08bad65adb8cae701c7527951e1a085bddf6 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Sat, 21 Jul 2018 02:40:46 +0530 Subject: [PATCH] Improve ClearOnExit behavior of cookies using domain matching https://chromium-review.googlesource.com/c/chromium/src/+/975861 --- atom/browser/special_storage_policy.cc | 8 ++++++-- atom/browser/special_storage_policy.h | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/atom/browser/special_storage_policy.cc b/atom/browser/special_storage_policy.cc index 7f94bcd298bc..b32c14356d4d 100644 --- a/atom/browser/special_storage_policy.cc +++ b/atom/browser/special_storage_policy.cc @@ -4,6 +4,9 @@ #include "atom/browser/special_storage_policy.h" +#include "base/bind.h" +#include "base/callback.h" + namespace atom { SpecialStoragePolicy::SpecialStoragePolicy() {} @@ -34,8 +37,9 @@ bool SpecialStoragePolicy::HasSessionOnlyOrigins() { return false; } -bool SpecialStoragePolicy::ShouldDeleteCookieOnExit(const GURL& origin) { - return false; +storage::SpecialStoragePolicy::DeleteCookiePredicate +SpecialStoragePolicy::CreateDeleteCookieOnExitPredicate() { + return storage::SpecialStoragePolicy::DeleteCookiePredicate(); } } // namespace atom diff --git a/atom/browser/special_storage_policy.h b/atom/browser/special_storage_policy.h index 7182bc38de9c..ce00ebbc31f6 100644 --- a/atom/browser/special_storage_policy.h +++ b/atom/browser/special_storage_policy.h @@ -20,7 +20,8 @@ class SpecialStoragePolicy : public storage::SpecialStoragePolicy { bool HasIsolatedStorage(const GURL& origin) override; bool IsStorageSessionOnly(const GURL& origin) override; bool HasSessionOnlyOrigins() override; - bool ShouldDeleteCookieOnExit(const GURL& origin) override; + storage::SpecialStoragePolicy::DeleteCookiePredicate + CreateDeleteCookieOnExitPredicate() override; protected: ~SpecialStoragePolicy() override;