migrate to non-deprecated v8 functions

https://bugs.chromium.org/p/v8/issues/detail?id=8238 https://bugs.chromium.org/p/v8/issues/detail?id=7295 1352273
2019-01-09 11:17:05 -08:00 · 2019-01-09 11:17:05 -08:00 · d01db5a656
commit d01db5a656
parent 7d5cd2051a
26 changed files with 94 additions and 46 deletions
--- a/atom/browser/api/atom_api_top_level_window.cc
+++ b/atom/browser/api/atom_api_top_level_window.cc
@ -1179,8 +1179,9 @@ void Initialize(v8::Local<v8::Object> exports,
  v8::Isolate* isolate = context->GetIsolate();
  TopLevelWindow::SetConstructor(isolate, base::Bind(&TopLevelWindow::New));

-  mate::Dictionary constructor(
-      isolate, TopLevelWindow::GetConstructor(isolate)->GetFunction());
+  mate::Dictionary constructor(isolate, TopLevelWindow::GetConstructor(isolate)
+                                            ->GetFunction(context)
+                                            .ToLocalChecked());
  constructor.SetMethod("fromId",
                        &mate::TrackableObject<TopLevelWindow>::FromWeakMapID);
  constructor.SetMethod("getAllWindows",