migrate to non-deprecated v8 functions

https://bugs.chromium.org/p/v8/issues/detail?id=8238 https://bugs.chromium.org/p/v8/issues/detail?id=7295 1352273
2019-01-09 11:17:05 -08:00 · 2019-01-09 11:17:05 -08:00 · d01db5a656
commit d01db5a656
parent 7d5cd2051a
26 changed files with 94 additions and 46 deletions
--- a/atom/browser/api/atom_api_notification.cc
+++ b/atom/browser/api/atom_api_notification.cc
@ -263,8 +263,9 @@ void Initialize(v8::Local<v8::Object> exports,
  Notification::SetConstructor(isolate, base::Bind(&Notification::New));

  mate::Dictionary dict(isolate, exports);
-  dict.Set("Notification",
-           Notification::GetConstructor(isolate)->GetFunction());
+  dict.Set("Notification", Notification::GetConstructor(isolate)
+                               ->GetFunction(context)
+                               .ToLocalChecked());

  dict.SetMethod("isSupported", &Notification::IsSupported);
 }