migrate to non-deprecated v8 functions

https://bugs.chromium.org/p/v8/issues/detail?id=8238 https://bugs.chromium.org/p/v8/issues/detail?id=7295 1352273
2019-01-09 11:17:05 -08:00 · 2019-01-09 11:17:05 -08:00 · d01db5a656
commit d01db5a656
parent 7d5cd2051a
26 changed files with 94 additions and 46 deletions
--- a/atom/browser/api/atom_api_browser_view.cc
+++ b/atom/browser/api/atom_api_browser_view.cc
@ -159,8 +159,9 @@ void Initialize(v8::Local<v8::Object> exports,
  v8::Isolate* isolate = context->GetIsolate();
  BrowserView::SetConstructor(isolate, base::Bind(&BrowserView::New));

-  mate::Dictionary browser_view(
-      isolate, BrowserView::GetConstructor(isolate)->GetFunction());
+  mate::Dictionary browser_view(isolate, BrowserView::GetConstructor(isolate)
+                                             ->GetFunction(context)
+                                             .ToLocalChecked());
  browser_view.SetMethod("fromId",
                         &mate::TrackableObject<BrowserView>::FromWeakMapID);
  browser_view.SetMethod("getAllViews",