From 817363b955f63f31545f35641955f1c15dfb7caf Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 15 Sep 2015 13:29:03 +0800 Subject: [PATCH 1/4] spec: Run tests on OS X CI machine --- script/cibuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/cibuild b/script/cibuild index 38ce06969a22..08d59385c9e0 100755 --- a/script/cibuild +++ b/script/cibuild @@ -71,7 +71,7 @@ def main(): run_script('upload.py') else: run_script('build.py', ['-c', 'D']) - if (is_travis or PLATFORM == 'linux') and target_arch == 'x64': + if PLATFORM != 'win32' and target_arch == 'x64': run_script('test.py', ['--ci']) run_script('clean.py') From 357c7af3c0f8db8e0aab5fe00b889062c2452ba2 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 15 Sep 2015 13:45:26 +0800 Subject: [PATCH 2/4] spec: Check existence of webview before removing it --- spec/webview-spec.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/webview-spec.coffee b/spec/webview-spec.coffee index ddb203399b8e..e4b40c28ebeb 100644 --- a/spec/webview-spec.coffee +++ b/spec/webview-spec.coffee @@ -11,7 +11,7 @@ describe ' tag', -> beforeEach -> webview = new WebView afterEach -> - document.body.removeChild webview + document.body.removeChild(webview) if document.body.contains(webview) describe 'src attribute', -> it 'specifies the page to load', (done) -> From eced01eb9d2dc77546692f2878c582f569aa485f Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 15 Sep 2015 14:26:46 +0800 Subject: [PATCH 3/4] spec: Delay timeout of window.opener test --- spec/chromium-spec.coffee | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/spec/chromium-spec.coffee b/spec/chromium-spec.coffee index d09a021db9f9..2c42cd9a4cf0 100644 --- a/spec/chromium-spec.coffee +++ b/spec/chromium-spec.coffee @@ -51,6 +51,8 @@ describe 'chromium feature', -> b = window.open "file://#{fixtures}/pages/window-opener-node.html", '', 'node-integration=no,show=no' describe 'window.opener', -> + @timeout 10000 + ipc = remote.require 'ipc' url = "file://#{fixtures}/pages/window-opener.html" w = null @@ -61,16 +63,17 @@ describe 'chromium feature', -> it 'is null for main window', (done) -> ipc.on 'opener', (event, opener) -> - done(if opener is null then undefined else opener) + assert.equal opener, null + done() BrowserWindow = remote.require 'browser-window' w = new BrowserWindow(show: false) w.loadUrl url it 'is not null for window opened by window.open', (done) -> - b = window.open url, '', 'show=no' ipc.on 'opener', (event, opener) -> b.close() done(if opener isnt null then undefined else opener) + b = window.open url, '', 'show=no' describe 'window.opener.postMessage', -> it 'sets source and origin correctly', (done) -> From f1787d747afbfcc9e6c416b298d7bf32a366241d Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 15 Sep 2015 14:43:11 +0800 Subject: [PATCH 4/4] The crash-reporter test is not reliable on CI machine --- spec/api-crash-reporter-spec.coffee | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/api-crash-reporter-spec.coffee b/spec/api-crash-reporter-spec.coffee index 1d34fe441412..60b630bc2ffc 100644 --- a/spec/api-crash-reporter-spec.coffee +++ b/spec/api-crash-reporter-spec.coffee @@ -18,6 +18,10 @@ describe 'crash-reporter module', -> # It is not working on 64bit Windows. return if process.platform is 'win32' and process.arch is 'x64' + # The crash-reporter test is not reliable on CI machine. + isCI = remote.process.argv[2] == '--ci' + return if isCI + it 'should send minidump when renderer crashes', (done) -> @timeout 120000 server = http.createServer (req, res) ->