mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: improve logging on http errors during release process (again) (#43757)

Browse source
This commit is contained in:
Samuel Attard 2024-09-17 14:49:59 -07:00 • committed by GitHub
commit cf4ab2186c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

11
script/release/get-asset.js
View file

@ -26,9 +26,9 @@ async function getAssetContents (repo, assetId) {
throwHttpErrors: false
});
if (response.status !== 302 && response.status !== 301) {
if (response.statusCode !== 302 && response.statusCode !== 301) {
console.error('Failed to HEAD github asset contents for redirect: ' + url);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.status);
throw new Error('Unexpected status HEAD\'ing github asset for redirect: ' + response.statusCode);
}
if (!response.headers.location) {
@ -40,14 +40,9 @@ async function getAssetContents (repo, assetId) {
throwHttpErrors: false
});
if (fileResponse.status !== 200) {
fileResponse.error(`Failed to download github asset contents: ${url} (via: ${response.headers.location})`);
throw new Error('Unexpected status fetching github asset: ' + fileResponse.status);
}
if (fileResponse.statusCode !== 200) {
console.error(fileResponse.headers, `${fileResponse.body}`.slice(0, 300));
throw new Error(`cannot download asset[${assetId}] from ${response.headers.location}, got status: ${fileResponse.status}`);
throw new Error(`cannot download asset[${assetId}] from ${response.headers.location}, got status: ${fileResponse.statusCode}`);
}
return fileResponse.body;

8
script/release/release.js
View file

@ -401,9 +401,9 @@ async function verifyDraftGitHubReleaseAssets (release) {
throwHttpErrors: false
});
if (response.status !== 200) {
if (response.statusCode !== 200) {
console.error('Failed to HEAD github asset: ' + url);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.status);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.statusCode);
}
return { url: response.headers.location, file: asset.name };
@ -420,10 +420,10 @@ async function getShaSumMappingFromUrl (shaSumFileUrl, fileNamePrefix) {
throwHttpErrors: false
});
if (response.status !== 200) {
if (response.statusCode !== 200) {
console.error('Failed to fetch SHASUM mapping: ' + shaSumFileUrl);
console.error('Bad SHASUM mapping response: ' + response.body.trim());
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.status);
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.statusCode);
}
const raw = response.body;