mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: improve logging on http errors during release process (again) (#43757)

Browse source
This commit is contained in:
Samuel Attard 2024-09-17 14:49:59 -07:00 • committed by GitHub
parent 10ba87a85e
commit cf4ab2186c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
script/release/release.js
View file

@ -401,9 +401,9 @@ async function verifyDraftGitHubReleaseAssets (release) {
throwHttpErrors: false
});
if (response.status !== 200) {
if (response.statusCode !== 200) {
console.error('Failed to HEAD github asset: ' + url);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.status);
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.statusCode);
}
return { url: response.headers.location, file: asset.name };
@ -420,10 +420,10 @@ async function getShaSumMappingFromUrl (shaSumFileUrl, fileNamePrefix) {
throwHttpErrors: false
});
if (response.status !== 200) {
if (response.statusCode !== 200) {
console.error('Failed to fetch SHASUM mapping: ' + shaSumFileUrl);
console.error('Bad SHASUM mapping response: ' + response.body.trim());
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.status);
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.statusCode);
}
const raw = response.body;