From ce733e5927a6c0273571130f51a068b865af03b9 Mon Sep 17 00:00:00 2001 From: leethomas Date: Fri, 1 Jan 2016 18:51:12 -0800 Subject: [PATCH] :white_check_mark: add tests to insure window.location.hash changes & window.history.replaceState cause 'did-navigate-in-page' to fire --- .../webview-did-navigate-in-page-with-hash.html | 9 +++++++++ ...bview-did-navigate-in-page-with-history.html | 9 +++++++++ spec/webview-spec.coffee | 17 +++++++++++++++++ 3 files changed, 35 insertions(+) create mode 100644 spec/fixtures/pages/webview-did-navigate-in-page-with-hash.html create mode 100644 spec/fixtures/pages/webview-did-navigate-in-page-with-history.html diff --git a/spec/fixtures/pages/webview-did-navigate-in-page-with-hash.html b/spec/fixtures/pages/webview-did-navigate-in-page-with-hash.html new file mode 100644 index 000000000000..894095d47f41 --- /dev/null +++ b/spec/fixtures/pages/webview-did-navigate-in-page-with-hash.html @@ -0,0 +1,9 @@ + + + + + diff --git a/spec/fixtures/pages/webview-did-navigate-in-page-with-history.html b/spec/fixtures/pages/webview-did-navigate-in-page-with-history.html new file mode 100644 index 000000000000..b32b7ebcd8a0 --- /dev/null +++ b/spec/fixtures/pages/webview-did-navigate-in-page-with-history.html @@ -0,0 +1,9 @@ + + + + + diff --git a/spec/webview-spec.coffee b/spec/webview-spec.coffee index 2e48b24c84c4..e03fa534bf60 100644 --- a/spec/webview-spec.coffee +++ b/spec/webview-spec.coffee @@ -301,6 +301,23 @@ describe ' tag', -> webview.src = page_url document.body.appendChild webview + it 'emits when window.history.replaceState is called', (done) -> + webview.addEventListener 'did-navigate-in-page', (e) -> + assert.equal e.url, "http://host/" + done() + + webview.src = "file://#{fixtures}/pages/webview-did-navigate-in-page-with-history.html" + document.body.appendChild webview + + it 'emits when window.location.hash is changed', (done) -> + page_url = "file://#{fixtures}/pages/webview-did-navigate-in-page-with-hash.html" + webview.addEventListener 'did-navigate-in-page', (e) -> + assert.equal e.url, "#{page_url}#test" + done() + + webview.src = page_url + document.body.appendChild webview + describe 'close event', -> it 'should fire when interior page calls window.close', (done) -> webview.addEventListener 'close', ->