mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix sandboxed crashReporter for windows.

Browse source 
- Use `path` module from browser process in sandboxed renderer. This is required
  because the return value of `path.join` is platform-specific, and this is an
  assumtion of crash-reporter.js which is shared between sandboxed and
  non-sandboxed renderers.
- Set `process.platform` and `process.execPath` in sandboxed renderer
  environment. This is required to spawn the windows crash service from
  sandboxed renderer.
- Use a single temporary directory for all crashReporter tests. This is required
  to make tests more deterministic across platforms(since mac's crashpad doesn't
  support changing the crash dump directory). Also make a few improvements/fixes
  to the `uploadToServer` test.
This commit is contained in:
Thiago de Arruda 2017-04-05 17:42:24 -03:00
parent 7574c33ef1
commit ce1a5e3c9c
5 changed files with 33 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/sandboxed_renderer/api/exports/path.js Normal file
View file

@ -0,0 +1 @@
module.exports = require('electron').remote.require('path')