mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

perf: avoid redundant map lookup in WebContents::DevToolsIndexPath() (#46296)

Browse source 
perf: avoid double map lookup in WebContents::DevToolsIndexPath()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-03-26 20:03:50 -05:00 • committed by GitHub
commit cd5da1b933
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

18
shell/browser/api/electron_api_web_contents.cc
View file

@ -4213,8 +4213,11 @@ void WebContents::DevToolsIndexPath(
OnDevToolsIndexingDone(request_id, file_system_path); OnDevToolsIndexingDone(request_id, file_system_path);
return; return;
} }
if (devtools_indexing_jobs_.contains(request_id))
auto& indexing_job = devtools_indexing_jobs_[request_id];
if (indexing_job)
return; return;
std::vector<std::string> excluded_folders; std::vector<std::string> excluded_folders;
std::optional<base::Value> parsed_excluded_folders = std::optional<base::Value> parsed_excluded_folders =
base::JSONReader::Read(excluded_folders_message); base::JSONReader::Read(excluded_folders_message);
@ -4224,19 +4227,18 @@ void WebContents::DevToolsIndexPath(
excluded_folders.push_back(folder_path.GetString()); excluded_folders.push_back(folder_path.GetString());
} }
} }
devtools_indexing_jobs_[request_id] =
scoped_refptr<DevToolsFileSystemIndexer::FileSystemIndexingJob>( indexing_job = devtools_file_system_indexer_->IndexPath(
devtools_file_system_indexer_->IndexPath(
file_system_path, excluded_folders, file_system_path, excluded_folders,
base::BindRepeating( base::BindRepeating(&WebContents::OnDevToolsIndexingWorkCalculated,
&WebContents::OnDevToolsIndexingWorkCalculated, weak_factory_.GetWeakPtr(), request_id,
weak_factory_.GetWeakPtr(), request_id, file_system_path), file_system_path),
base::BindRepeating(&WebContents::OnDevToolsIndexingWorked, base::BindRepeating(&WebContents::OnDevToolsIndexingWorked,
weak_factory_.GetWeakPtr(), request_id, weak_factory_.GetWeakPtr(), request_id,
file_system_path), file_system_path),
base::BindRepeating(&WebContents::OnDevToolsIndexingDone, base::BindRepeating(&WebContents::OnDevToolsIndexingDone,
weak_factory_.GetWeakPtr(), request_id, weak_factory_.GetWeakPtr(), request_id,
file_system_path))); file_system_path));
} }
void WebContents::DevToolsStopIndexing(int request_id) { void WebContents::DevToolsStopIndexing(int request_id) {