From cd19d7c705f06911dee95445800a200b9f26740c Mon Sep 17 00:00:00 2001
From: Shelley Vohr <shelley.vohr@gmail.com>
Date: Tue, 31 Oct 2017 10:38:48 -0400
Subject: [PATCH] add crashReporter parameter tests

---
 spec/api-crash-reporter-spec.js | 38 ++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/spec/api-crash-reporter-spec.js b/spec/api-crash-reporter-spec.js
index ad688f26b607..411186205eae 100644
--- a/spec/api-crash-reporter-spec.js
+++ b/spec/api-crash-reporter-spec.js
@@ -11,7 +11,7 @@ const {closeWindow} = require('./window-helpers')
 const {remote} = require('electron')
 const {app, BrowserWindow, crashReporter} = remote.require('electron')
 
-describe.only('crashReporter module', () => {
+describe('crashReporter module', () => {
   if (process.mas || process.env.DISABLE_CRASH_REPORTER_TESTS) return
 
   let originalTempDirectory = null
@@ -197,11 +197,10 @@ describe.only('crashReporter module', () => {
     }
   })
 
-  // complete
   describe('getProductName', () => {
     it('returns the product name if one is specified', () => {
       const name = crashReporter.getProductName()
-      if(process.platform === 'win32') {
+      if (process.platform === 'win32') {
         assert.equal(name, 'Zombies')
       } else {
         assert.equal(name, 'Electron Test')
@@ -240,7 +239,6 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  // complete
   describe('getCrashesDirectory', () => {
     it('correctly returns the directory', () => {
       const crashesDir = crashReporter.getCrashesDirectory()
@@ -254,7 +252,6 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  // complete
   describe('getUploadedReports', () => {
     it('returns an array of reports', () => {
       const reports = crashReporter.getUploadedReports()
@@ -262,7 +259,6 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  // complete
   describe('getLastCrashReport', () => {
     it('correctly returns the most recent report', () => {
       const reports = crashReporter.getUploadedReports()
@@ -271,7 +267,6 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  // complete
   describe('getUploadToServer()', () => {
     it('throws an error when called from the renderer process', () => {
       assert.throws(() => require('electron').crashReporter.getUploadToServer())
@@ -298,7 +293,6 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  // complete
   describe('setUploadToServer(uploadToServer)', () => {
     it('throws an error when called from the renderer process', () => {
       assert.throws(() => require('electron').crashReporter.setUploadToServer('arg'))
@@ -327,8 +321,32 @@ describe.only('crashReporter module', () => {
     })
   })
 
-  describe('setExtraParameter', () => {
-    //
+  describe('Parameters', () => {
+    it('returns all of the current parameters', () => {
+      const parameters = crashReporter.getParameters()
+      assert(typeof parameters === Object)
+    })
+    it('adds a parameter', () => {
+      // only run on MacOS
+      if (process.platform !== 'darwin') return
+
+      crashReporter.addParameter('hello', 'world')
+      const updatedParams = crashReporter.getParameters()
+
+      assert(updatedParams.includes('hello'))
+    })
+    it('removes a parameter', () => {
+      // only run on MacOS
+      if (process.platform !== 'darwin') return
+
+      crashReporter.addParameter('hello', 'world')
+      const originalParams = crashReporter.getParameters()
+      assert(originalParams.includes('hello'))
+
+      crashReporter.removeExtraParameter('hello')
+      const updatedParams = crashReporter.getParameters()
+      assert(!updatedParams.includes('hello'))
+    })
   })
 })