mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: window ordering on mac (#29857)

Browse source
This commit is contained in:
Robo 2021-07-10 05:38:25 +09:00 committed by GitHub
parent 98f617e856
commit ccfde6c9d4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/native_window_mac.mm
View file

@ -1682,8 +1682,6 @@ void NativeWindowMac::NotifyWindowWillLeaveFullScreen() {
} }
void NativeWindowMac::SetActive(bool is_key) { void NativeWindowMac::SetActive(bool is_key) {
if (is_key)
widget()->Activate();
is_active_ = is_key; is_active_ = is_key;
} }

12
spec-main/api-browser-window-spec.ts
View file

@ -4203,6 +4203,18 @@ describe('BrowserWindow module', () => {
await leaveFullScreen; await leaveFullScreen;
expect(w.isFullScreen()).to.be.false('isFullScreen'); expect(w.isFullScreen()).to.be.false('isFullScreen');
}); });
it('multiple windows inherit correct fullscreen state', async () => {
const w = new BrowserWindow();
const enterFullScreen = emittedOnce(w, 'enter-full-screen');
w.setFullScreen(true);
await enterFullScreen;
expect(w.isFullScreen()).to.be.true('isFullScreen');
await delay();
const w2 = new BrowserWindow();
await delay();
expect(w2.isFullScreen()).to.be.true('isFullScreen');
});
}); });
describe('closable state', () => { describe('closable state', () => {