From ccd4a3c80c45cff2a17ca887e101cbf81e7e0c24 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Thu, 21 Feb 2019 22:33:22 +0530 Subject: [PATCH] CookieStore::DeleteCookieAsync appears unused (outside a few tests), so remove it https://chromium-review.googlesource.com/c/chromium/src/+/1456677 --- atom/browser/api/atom_api_cookies.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/atom/browser/api/atom_api_cookies.cc b/atom/browser/api/atom_api_cookies.cc index b4dc8232d382..eba67957bd24 100644 --- a/atom/browser/api/atom_api_cookies.cc +++ b/atom/browser/api/atom_api_cookies.cc @@ -175,9 +175,16 @@ void RemoveCookieOnIO(scoped_refptr getter, const GURL& url, const std::string& name, util::Promise promise) { - GetCookieStore(getter)->DeleteCookieAsync( - url, name, - base::BindOnce(util::Promise::ResolveEmptyPromise, std::move(promise))); + net::CookieDeletionInfo cookie_info; + cookie_info.url = url; + cookie_info.name = name; + GetCookieStore(getter)->DeleteAllMatchingInfoAsync( + std::move(cookie_info), + base::BindOnce( + [](util::Promise promise, uint32_t num_deleted) { + util::Promise::ResolveEmptyPromise(std::move(promise)); + }, + std::move(promise))); } // Callback of SetCookie.