mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #5964 from electron/manifest-errors

Browse source 
Throw errors reading/parsing manifest.json files
This commit is contained in:
Cheng Zhao 2016-06-10 03:28:57 +00:00 • committed by GitHub
commit ccaf837da4
3 changed files with 28 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/api-browser-window-spec.js
View file

@ -858,6 +858,18 @@ describe('browser-window module', function () {
w.loadURL('about:blank')
})
it('throws errors for missing manifest.json files', function () {
assert.throws(function () {
BrowserWindow.addDevToolsExtension(path.join(__dirname, 'does-not-exist'))
}, /ENOENT: no such file or directory/)
})
it('throws errors for invalid manifest.json files', function () {
assert.throws(function () {
BrowserWindow.addDevToolsExtension(path.join(__dirname, 'fixtures', 'devtools-extensions', 'bad-manifest'))
}, /Unexpected token }/)
})
describe('when the devtools is docked', function () {
it('creates the extension', function (done) {
w.webContents.openDevTools({mode: 'bottom'})