mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove returns from event listeners

Browse source
This commit is contained in:
Kevin Sawicki 2016-05-19 15:28:08 -07:00
parent a2b6731bf2
commit cc7395eea8
15 changed files with 34 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/renderer/api/desktop-capturer.js
View file

@ -30,7 +30,7 @@ exports.getSources = function (options, callback) {
ipcRenderer.send('ELECTRON_BROWSER_DESKTOP_CAPTURER_GET_SOURCES', captureWindow, captureScreen, options.thumbnailSize, id)
return ipcRenderer.once('ELECTRON_RENDERER_DESKTOP_CAPTURER_RESULT_' + id, function (event, sources) {
var source
return callback(null, (function () {
callback(null, (function () {
var i, len, results
results = []
for (i = 0, len = sources.length; i < len; i++) {

4
lib/renderer/api/remote.js
View file

@ -238,12 +238,12 @@ var metaToPlainObject = function (meta) {
// Browser calls a callback in renderer.
ipcRenderer.on('ELECTRON_RENDERER_CALLBACK', function (event, id, args) {
return callbacksRegistry.apply(id, metaToValue(args))
callbacksRegistry.apply(id, metaToValue(args))
})
// A callback in browser is released.
ipcRenderer.on('ELECTRON_RENDERER_RELEASE_CALLBACK', function (event, id) {
return callbacksRegistry.remove(id)
callbacksRegistry.remove(id)
})
// List all built-in modules in browser process.

2
lib/renderer/inspector.js
View file

@ -3,7 +3,7 @@ window.onload = function () {
window.InspectorFrontendHost.showContextMenuAtPoint = createMenu
// Use dialog API to override file chooser dialog.
return (window.WebInspector.createFileSelectorElement = createFileSelectorElement)
window.WebInspector.createFileSelectorElement = createFileSelectorElement
}
var convertToMenuTemplate = function (items) {

2
lib/renderer/override.js
View file

@ -193,7 +193,7 @@ ipcRenderer.on('ELECTRON_GUEST_WINDOW_POSTMESSAGE', function (event, sourceId, m
event.data = message
event.origin = sourceOrigin
event.source = BrowserWindowProxy.getOrCreate(sourceId)
return window.dispatchEvent(event)
window.dispatchEvent(event)
})
// Forward history operations to browser.

6
lib/renderer/web-view/guest-view-internal.js
View file

@ -62,14 +62,14 @@ var dispatchEvent = function (webView, eventName, eventKey, ...args) {
module.exports = {
registerEvents: function (webView, viewInstanceId) {
ipcRenderer.on('ELECTRON_GUEST_VIEW_INTERNAL_DISPATCH_EVENT-' + viewInstanceId, function (event, eventName, ...args) {
return dispatchEvent.apply(null, [webView, eventName, eventName].concat(args))
dispatchEvent.apply(null, [webView, eventName, eventName].concat(args))
})
ipcRenderer.on('ELECTRON_GUEST_VIEW_INTERNAL_IPC_MESSAGE-' + viewInstanceId, function (event, channel, ...args) {
var domEvent = new Event('ipc-message')
domEvent.channel = channel
domEvent.args = args
return webView.dispatchEvent(domEvent)
webView.dispatchEvent(domEvent)
})
return ipcRenderer.on('ELECTRON_GUEST_VIEW_INTERNAL_SIZE_CHANGED-' + viewInstanceId, function (event, ...args) {
@ -80,7 +80,7 @@ module.exports = {
f = ref1[i]
domEvent[f] = args[i]
}
return webView.onSizeChanged(domEvent)
webView.onSizeChanged(domEvent)
})
},
deregisterEvents: function (viewInstanceId) {