fix: delete UvTaskRunner's timers only after they're closed (#43561)
* fix: free UvTaskRunner timers only after they are closed * refactor: UvTaskRunner now holds UvHandles
This commit is contained in:
parent
25f4691e78
commit
cc5aa65cb4
3 changed files with 42 additions and 35 deletions
|
@ -9,7 +9,7 @@
|
|||
|
||||
#include "base/memory/raw_ptr.h"
|
||||
#include "base/task/single_thread_task_runner.h"
|
||||
#include "uv.h" // NOLINT(build/include_directory)
|
||||
#include "shell/common/node_bindings.h"
|
||||
|
||||
namespace base {
|
||||
class Location;
|
||||
|
@ -38,12 +38,10 @@ class UvTaskRunner : public base::SingleThreadTaskRunner {
|
|||
|
||||
private:
|
||||
~UvTaskRunner() override;
|
||||
static void OnTimeout(uv_timer_t* timer);
|
||||
static void OnClose(uv_handle_t* handle);
|
||||
|
||||
raw_ptr<uv_loop_t> loop_;
|
||||
|
||||
std::map<uv_timer_t*, base::OnceClosure> tasks_;
|
||||
std::map<UvHandle<uv_timer_t>, base::OnceClosure, UvHandleCompare> tasks_;
|
||||
};
|
||||
|
||||
} // namespace electron
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue