mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

better crash diagnostics in ffmpeg test

Browse source
This commit is contained in:
Jeremy Apthorp 2018-09-20 14:15:33 -07:00 committed by Aleksei Kuzmin
parent 6ab5c2faa1
commit cc53269231
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
script/verify-ffmpeg.py
View file

@ -41,7 +41,10 @@ def main():
try: try:
test_path = os.path.join(SOURCE_ROOT, 'spec', 'fixtures', test_path = os.path.join(SOURCE_ROOT, 'spec', 'fixtures',
'no-proprietary-codecs.js') 'no-proprietary-codecs.js')
subprocess.check_call([electron, test_path] + sys.argv[1:]) env = dict(os.environ)
env['ELECTRON_ENABLE_STACK_DUMPING'] = 'true'
env['ELECTRON_ENABLE_LOGGING'] = 'true'
subprocess.check_call([electron, test_path] + sys.argv[1:], env=env)
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
returncode = e.returncode returncode = e.returncode
except KeyboardInterrupt: except KeyboardInterrupt:

5
spec/fixtures/no-proprietary-codecs.js vendored
View file

@ -17,6 +17,11 @@ app.once('ready', () => {
show: false show: false
}) })
window.webContents.on('crashed', (event, killed) => {
console.log(`WebContents crashed (killed=${killed})`)
app.exit(1)
})
window.loadFile(path.resolve(__dirname, 'asar', 'video.asar', 'index.html')) window.loadFile(path.resolve(__dirname, 'asar', 'video.asar', 'index.html'))
ipcMain.on('asar-video', (event, message, error) => { ipcMain.on('asar-video', (event, message, error) => {