From 02d072ed9d742fbd0d10683735da98d4a6e8fd3c Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 13 Jul 2018 13:47:40 -0500 Subject: [PATCH 1/5] fix VSTS token generation URL --- docs/development/releasing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index 7fe929515bcd..f454b6b961c7 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -19,7 +19,7 @@ If you don't have an account, ask a team member to add you. * `CIRCLE_TOKEN`: Create a token from "Personal API Tokens" at https://circleci.com/account/api * `VSTS_TOKEN`: -Create a Personal Access Token at https://github.visualstudio.com/_usersSettings/tokens +Create a Personal Access Token at https://github.visualstudio.com/_details/security/tokens with the scope of `Build (read and execute)`. ## Determine which branch to release from From 452b5f342c5402754503b1bcc0aa7a4f6c39efbd Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 13 Jul 2018 14:17:31 -0500 Subject: [PATCH 2/5] add note about multiple calls to validateRelease --- docs/development/releasing.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index f454b6b961c7..dfb1bdbd63ec 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -65,7 +65,7 @@ npm run prepare-release -- minor ``` ### Patch version change ```sh -npm run prepare-release -- patch +npm run prepare-release -- patch --stable ``` ### Beta version change ```sh @@ -204,6 +204,10 @@ release notes. ```sh $ npm run release -- --validateRelease ``` +Note, if you need to run `--validateRelease` more than once to check the assets, +run it as above the first time, then `node ./script/release.js --validateRelase` +for subsequent calls so that you don't have to rebuild each time you want to +check the assets. ## Publish the release From da92abf96498d3edf7c25caf1d814f0fc6ea4f54 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 13 Jul 2018 14:42:36 -0500 Subject: [PATCH 3/5] document ELECTRON_S3_ tokens --- docs/development/releasing.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index dfb1bdbd63ec..d992491862e6 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -21,6 +21,10 @@ Create a token from "Personal API Tokens" at https://circleci.com/account/api * `VSTS_TOKEN`: Create a Personal Access Token at https://github.visualstudio.com/_details/security/tokens with the scope of `Build (read and execute)`. +* `ELECTRON_S3_BUCKET`: +* `ELECTRON_S3_ACCESS_KEY`: +* `ELECTRON_S3_SECRET_KEY`: +If you don't have these, ask a team member to help you. ## Determine which branch to release from @@ -205,7 +209,7 @@ release notes. $ npm run release -- --validateRelease ``` Note, if you need to run `--validateRelease` more than once to check the assets, -run it as above the first time, then `node ./script/release.js --validateRelase` +run it as above the first time, then `node ./script/release.js --validateRelease` for subsequent calls so that you don't have to rebuild each time you want to check the assets. From 3653730cbad519e3ff993236c795b4a55801a1f0 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 13 Jul 2018 16:17:02 -0500 Subject: [PATCH 4/5] Add post-publish 'npm dist-tag ls electron' step --- docs/development/releasing.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index d992491862e6..7d5d4c006334 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -255,6 +255,21 @@ electron $ npm run publish-to-npm ``` +After publishing, you can check the `latest` release: +```sh +$ npm dist-tag ls electron +``` + +If for some reason `npm run publish-to-npm` fails, +you can tag the release manually: +```sh +$ npm dist-tag add electron@ +``` +e.g.: +```sh +$ npm dist-tag add electron@2.0.0 latest +``` + [the releases page]: https://github.com/electron/electron/releases [this bump commit]: https://github.com/electron/electron/commit/78ec1b8f89b3886b856377a1756a51617bc33f5a [versioning]: /docs/tutorial/electron-versioning.md From 5764d76efa2cd6b9ab358bc8ccdd265a4408d300 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 16 Jul 2018 10:39:31 -0400 Subject: [PATCH 5/5] Fix formatting Add alternate url for security token (depends on whether you are using new or old navigation on VSTS) --- docs/development/releasing.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index 7d5d4c006334..7145b98224bd 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -19,7 +19,7 @@ If you don't have an account, ask a team member to add you. * `CIRCLE_TOKEN`: Create a token from "Personal API Tokens" at https://circleci.com/account/api * `VSTS_TOKEN`: -Create a Personal Access Token at https://github.visualstudio.com/_details/security/tokens +Create a Personal Access Token at https://github.visualstudio.com/_usersSettings/tokens or https://github.visualstudio.com/_details/security/tokens with the scope of `Build (read and execute)`. * `ELECTRON_S3_BUCKET`: * `ELECTRON_S3_ACCESS_KEY`: @@ -299,7 +299,7 @@ node script/ci-release-build.js --ci=AppVeyor --ghRelease TARGET_BRANCH ``` Additionally you can pass a job name to the script to run an individual job, eg: -````sh +```sh node script/ci-release-build.js --ci=AppVeyor --ghRelease --job=electron-x64 TARGET_BRANCH ```