From cb911b19dd3f3d028648c961db4529ade5ef69f2 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Mon, 15 Dec 2014 17:27:58 -0800 Subject: [PATCH] win: Fixes stopping FlashFrame, closes #906 --- atom/browser/native_window_views.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/atom/browser/native_window_views.cc b/atom/browser/native_window_views.cc index 80fcfc539c26..93b73f58446a 100644 --- a/atom/browser/native_window_views.cc +++ b/atom/browser/native_window_views.cc @@ -489,6 +489,18 @@ std::string NativeWindowViews::GetTitle() { } void NativeWindowViews::FlashFrame(bool flash) { +#if defined(OS_WIN) + // The Chromium's implementation has a bug stopping flash. + if (!flash) { + FLASHWINFO fwi; + fwi.cbSize = sizeof(fwi); + fwi.hwnd = GetAcceleratedWidget(); + fwi.dwFlags = FLASHW_STOP; + fwi.uCount = 0; + FlashWindowEx(&fwi); + return; + } +#endif window_->FlashFrame(flash); }