mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: add patch to fix desktopCapturer.getSources not returning electron windows on Windows (#45000)

Browse source 
* fix: add patch to fix desktopCapturer.getSources not returning electron window on Windows

* add chromium link

* Update patches/chromium/fix_desktop_capturer_show_own_window.patch

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

* fix on electron side

* set flag to true

* wrong capturer

---------

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
This commit is contained in:
George Xu 2024-12-17 15:20:44 -08:00 • committed by GitHub
parent ff13bcd08d
commit caf24ef417
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_desktop_capturer.cc
View file

@ -286,7 +286,7 @@ void DesktopCapturer::StartHandling(bool capture_window,
capture_screen_ = false; capture_screen_ = false;
capture_window_ = capture_window; capture_window_ = capture_window;
window_capturer_ = std::make_unique<NativeDesktopMediaList>( window_capturer_ = std::make_unique<NativeDesktopMediaList>(
DesktopMediaList::Type::kWindow, std::move(capturer)); DesktopMediaList::Type::kWindow, std::move(capturer), true, true);
window_capturer_->SetThumbnailSize(thumbnail_size); window_capturer_->SetThumbnailSize(thumbnail_size);
OnceCallback update_callback = base::BindOnce( OnceCallback update_callback = base::BindOnce(
@ -322,7 +322,7 @@ void DesktopCapturer::StartHandling(bool capture_window,
auto capturer = MakeWindowCapturer(); auto capturer = MakeWindowCapturer();
if (capturer) { if (capturer) {
window_capturer_ = std::make_unique<NativeDesktopMediaList>( window_capturer_ = std::make_unique<NativeDesktopMediaList>(
DesktopMediaList::Type::kWindow, std::move(capturer)); DesktopMediaList::Type::kWindow, std::move(capturer), true, true);
window_capturer_->SetThumbnailSize(thumbnail_size); window_capturer_->SetThumbnailSize(thumbnail_size);
#if BUILDFLAG(IS_MAC) #if BUILDFLAG(IS_MAC)
window_capturer_->skip_next_refresh_ = window_capturer_->skip_next_refresh_ =