mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: Add ContentsView to AXChildren (#22399)

Browse source
This commit is contained in:
Felix Rieseberg 2020-03-01 18:25:40 -08:00 • committed by GitHub
commit cad7054e4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
shell/browser/ui/cocoa/electron_ns_window.mm
View file

@ -121,7 +121,18 @@ bool ScopedDisableResize::disable_resize_ = false;
[NSButtonCell class], @"RenderWidgetHostViewCocoa"];
NSArray* children = [super accessibilityAttributeValue:attribute];
return [children filteredArrayUsingPredicate:predicate];
NSMutableArray* mutableChildren = [[children mutableCopy] autorelease];
[mutableChildren filterUsingPredicate:predicate];
// We need to add the web contents: Without us doing so, VoiceOver
// users will be able to navigate up the a11y tree, but not back down.
// The content view contains the "web contents", which VoiceOver
// immediately understands.
NSView* contentView =
[shell_->GetNativeWindow().GetNativeNSWindow() contentView];
[mutableChildren addObject:contentView];
return mutableChildren;
}
- (NSString*)accessibilityTitle {