mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: promisify app.dock.show() (#16904)

Browse source 
* feat: promisify app.dock.show

* add a spec
This commit is contained in:
Shelley Vohr 2019-02-12 21:06:33 -08:00 • committed by GitHub
parent cd9bf72ee8
commit ca83d36426
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 30 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

32
spec/api-app-spec.js
View file

@ -1110,17 +1110,29 @@ describe('app module', () => {
})
})
describe('dock.setMenu', () => {
before(function () {
if (process.platform !== 'darwin') {
this.skip()
}
describe('dock APIs', () => {
describe('dock.setMenu()', () => {
it('keeps references to the menu', function () {
if (process.platform !== 'darwin') this.skip()
app.dock.setMenu(new Menu())
const v8Util = process.atomBinding('v8_util')
v8Util.requestGarbageCollectionForTesting()
})
})
it('keeps references to the menu', () => {
app.dock.setMenu(new Menu())
const v8Util = process.atomBinding('v8_util')
v8Util.requestGarbageCollectionForTesting()
describe('dock.show()', () => {
before(function () {
if (process.platform !== 'darwin') this.skip()
})
it('returns a Promise', () => {
expect(app.dock.show()).to.be.a('promise')
})
it('eventually fulfills', () => {
expect(app.dock.show()).to.be.eventually.fulfilled()
})
})
})
@ -1131,7 +1143,7 @@ describe('app module', () => {
it('becomes fulfilled if the app is already ready', () => {
expect(app.isReady()).to.be.true()
return expect(app.whenReady()).to.be.eventually.fulfilled
expect(app.whenReady()).to.be.eventually.fulfilled()
})
})