From ca4b4709e57d9c1a1c0e0ff9bd8f5fcb963a7d44 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Tue, 23 Oct 2018 07:35:00 -0700 Subject: [PATCH] fix: Native window close crash (#15327) --- atom/browser/ui/cocoa/atom_ns_window_delegate.mm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/atom/browser/ui/cocoa/atom_ns_window_delegate.mm b/atom/browser/ui/cocoa/atom_ns_window_delegate.mm index 2b588a59be2a..b96316a3ee75 100644 --- a/atom/browser/ui/cocoa/atom_ns_window_delegate.mm +++ b/atom/browser/ui/cocoa/atom_ns_window_delegate.mm @@ -9,6 +9,7 @@ #include "atom/browser/ui/cocoa/atom_preview_item.h" #include "atom/browser/ui/cocoa/atom_touch_bar.h" #include "base/mac/mac_util.h" +#include "ui/views/cocoa/bridged_native_widget.h" #include "ui/views/widget/native_widget_mac.h" @implementation AtomNSWindowDelegate @@ -246,7 +247,10 @@ // Clears the delegate when window is going to be closed, since EL Capitan it // is possible that the methods of delegate would get called after the window // has been closed. - [shell_->GetNativeWindow() setDelegate:nil]; + views::BridgedNativeWidget* bridged_view = + views::NativeWidgetMac::GetBridgeForNativeWindow( + shell_->GetNativeWindow()); + bridged_view->OnWindowWillClose(); } - (BOOL)windowShouldClose:(id)window {