mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: allow retries for flaky mas loginitem specs (#16347)

Browse source
This commit is contained in:
Shelley Vohr 2019-01-10 14:15:47 -08:00 committed by GitHub
parent 52852b963a
commit ca218b6395
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
spec/api-app-spec.js
View file

@ -528,7 +528,10 @@ describe('app module', () => {
}) })
}) })
describe('app.get/setLoginItemSettings API', () => { describe('app.get/setLoginItemSettings API', function () {
// allow up to three retries to account for flaky mas results
this.retries(3)
const updateExe = path.resolve(path.dirname(process.execPath), '..', 'Update.exe') const updateExe = path.resolve(path.dirname(process.execPath), '..', 'Update.exe')
const processStartArgs = [ const processStartArgs = [
'--processStart', `"${path.basename(process.execPath)}"`, '--processStart', `"${path.basename(process.execPath)}"`,
@ -536,9 +539,7 @@ describe('app module', () => {
] ]
before(function () { before(function () {
if (process.platform === 'linux') { if (process.platform === 'linux') this.skip()
this.skip()
}
}) })
beforeEach(() => { beforeEach(() => {
@ -609,11 +610,7 @@ describe('app module', () => {
}) })
it('allows you to pass a custom executable and arguments', function () { it('allows you to pass a custom executable and arguments', function () {
if (process.platform !== 'win32') { if (process.platform !== 'win32') this.skip()
// FIXME(alexeykuzmin): Skip the test.
// this.skip()
return
}
app.setLoginItemSettings({ openAtLogin: true, path: updateExe, args: processStartArgs }) app.setLoginItemSettings({ openAtLogin: true, path: updateExe, args: processStartArgs })