mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix typos in 'shell/' folder. (#43373)

Browse source
This commit is contained in:
Alexander Cyon 2024-08-23 02:48:32 +02:00 • committed by GitHub
parent 1aeca6fd0e
commit ca0837c852
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

40
shell/common/gin_helper/callback.cc
View file

@ -12,30 +12,30 @@ namespace gin_helper {
namespace {
struct TranslaterHolder {
explicit TranslaterHolder(v8::Isolate* isolate)
struct TranslatorHolder {
explicit TranslatorHolder(v8::Isolate* isolate)
: handle(isolate, v8::External::New(isolate, this)) {
handle.SetWeak(this, &GC, v8::WeakCallbackType::kParameter);
}
~TranslaterHolder() {
~TranslatorHolder() {
if (!handle.IsEmpty()) {
handle.ClearWeak();
handle.Reset();
}
}
static void GC(const v8::WeakCallbackInfo<TranslaterHolder>& data) {
static void GC(const v8::WeakCallbackInfo<TranslatorHolder>& data) {
delete data.GetParameter();
}
v8::Global<v8::External> handle;
Translater translater;
Translator translator;
};
// Cached JavaScript version of |CallTranslater|.
v8::Persistent<v8::FunctionTemplate> g_call_translater;
// Cached JavaScript version of |CallTranslator|.
v8::Persistent<v8::FunctionTemplate> g_call_translator;
void CallTranslater(v8::Local<v8::External> external,
void CallTranslator(v8::Local<v8::External> external,
v8::Local<v8::Object> state,
gin::Arguments* args) {
// Whether the callback should only be called once.
@ -56,8 +56,8 @@ void CallTranslater(v8::Local<v8::External> external,
}
}
auto* holder = static_cast<TranslaterHolder*>(external->Value());
holder->translater.Run(args);
auto* holder = static_cast<TranslatorHolder*>(external->Value());
holder->translator.Run(args);
// Free immediately for one-time callback.
if (one_time)
@ -113,25 +113,25 @@ v8::Local<v8::Function> SafeV8Function::NewHandle(v8::Isolate* isolate) const {
return v8_function_->NewHandle(isolate);
}
v8::Local<v8::Value> CreateFunctionFromTranslater(v8::Isolate* isolate,
const Translater& translater,
v8::Local<v8::Value> CreateFunctionFromTranslator(v8::Isolate* isolate,
const Translator& translator,
bool one_time) {
// The FunctionTemplate is cached.
if (g_call_translater.IsEmpty())
g_call_translater.Reset(
if (g_call_translator.IsEmpty())
g_call_translator.Reset(
isolate,
CreateFunctionTemplate(isolate, base::BindRepeating(&CallTranslater)));
CreateFunctionTemplate(isolate, base::BindRepeating(&CallTranslator)));
v8::Local<v8::FunctionTemplate> call_translater =
v8::Local<v8::FunctionTemplate>::New(isolate, g_call_translater);
auto* holder = new TranslaterHolder(isolate);
holder->translater = translater;
v8::Local<v8::FunctionTemplate> call_translator =
v8::Local<v8::FunctionTemplate>::New(isolate, g_call_translator);
auto* holder = new TranslatorHolder(isolate);
holder->translator = translator;
auto state = gin::Dictionary::CreateEmpty(isolate);
if (one_time)
state.Set("oneTime", true);
auto context = isolate->GetCurrentContext();
return BindFunctionWith(
isolate, context, call_translater->GetFunction(context).ToLocalChecked(),
isolate, context, call_translator->GetFunction(context).ToLocalChecked(),
holder->handle.Get(isolate), gin::ConvertToV8(isolate, state));
}