fix: Showing the about panel is async on all platforms (#37440)
* fix: about panel is a base::Value::Dict * nix this test for a diff PR * what if the about dialog was not blocking * add this test back in * document synchronicity * github editor is a fan of spaces
This commit is contained in:
parent
829fb4f586
commit
c8f715f9a1
4 changed files with 13 additions and 4 deletions
|
@ -2,6 +2,7 @@
|
|||
// Use of this source code is governed by the MIT license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
#include "base/functional/bind.h"
|
||||
#include "shell/browser/browser.h"
|
||||
|
||||
// must come before other includes. fixes bad #defines from <shlwapi.h>.
|
||||
|
@ -765,7 +766,8 @@ void Browser::ShowAboutPanel() {
|
|||
settings.message = aboutMessage;
|
||||
settings.icon = image;
|
||||
settings.type = electron::MessageBoxType::kInformation;
|
||||
electron::ShowMessageBoxSync(settings);
|
||||
electron::ShowMessageBox(settings,
|
||||
base::BindOnce([](int, bool) { /* do nothing. */ }));
|
||||
}
|
||||
|
||||
void Browser::SetAboutPanelOptions(base::Value::Dict options) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue