mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: Showing the about panel is async on all platforms (#37440)

Browse source 
* fix: about panel is a base::Value::Dict

* nix this test for a diff PR

* what if the about dialog was not blocking

* add this test back in

* document synchronicity

* github editor is a fan of spaces
This commit is contained in:
Calvin 2023-03-06 07:46:35 -07:00 • committed by GitHub
parent 829fb4f586
commit c8f715f9a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/browser_linux.cc
View file

@ -212,8 +212,11 @@ void Browser::ShowAboutPanel() {
}
}
gtk_dialog_run(GTK_DIALOG(dialog));
gtk_widget_destroy(dialogWidget);
// destroy the widget when it closes
g_signal_connect_swapped(dialogWidget, "response",
G_CALLBACK(gtk_widget_destroy), dialogWidget);
gtk_widget_show_all(dialogWidget);
}
void Browser::SetAboutPanelOptions(base::Value::Dict options) {