mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: in GTK open dialog, do not preview huge files (#31799)

Browse source
This commit is contained in:
Charles Kerr 2021-11-15 01:17:11 -06:00 • committed by GitHub
parent a6a5ca1db3
commit c8ba3b4556
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/ui/file_dialog_gtk.cc
View file

@ -369,6 +369,20 @@ void FileChooserDialog::AddFilters(const Filters& filters) {
} }
} }
bool CanPreview(const struct stat& st) {
// Only preview regular files; pipes may hang.
// See https://crbug.com/534754.
if (!S_ISREG(st.st_mode)) {
return false;
}
// Don't preview huge files; they may crash.
// https://github.com/electron/electron/issues/31630
// Setting an arbitrary filesize max t at 100 MB here.
constexpr off_t ArbitraryMax = 100000000ULL;
return st.st_size < ArbitraryMax;
}
void FileChooserDialog::OnUpdatePreview(GtkFileChooser* chooser) { void FileChooserDialog::OnUpdatePreview(GtkFileChooser* chooser) {
CHECK(!*supports_gtk_file_chooser_native); CHECK(!*supports_gtk_file_chooser_native);
gchar* filename = gtk_file_chooser_get_preview_filename(chooser); gchar* filename = gtk_file_chooser_get_preview_filename(chooser);
@ -377,10 +391,8 @@ void FileChooserDialog::OnUpdatePreview(GtkFileChooser* chooser) {
return; return;
} }
// Don't attempt to open anything which isn't a regular file. If a named struct stat sb;
// pipe, this may hang. See https://crbug.com/534754. if (stat(filename, &sb) != 0 || !CanPreview(sb)) {
struct stat stat_buf;
if (stat(filename, &stat_buf) != 0 || !S_ISREG(stat_buf.st_mode)) {
g_free(filename); g_free(filename);
gtk_file_chooser_set_preview_widget_active(chooser, FALSE); gtk_file_chooser_set_preview_widget_active(chooser, FALSE);
return; return;