mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: Correct modal focus behavior on macOS (#18995)

Browse source 
Fixes #18502

This PR changes the focus and blur events that we emit in Electron to listen to changes in key window rather than main window. It swaps out windowDidBecomeMain and windowDidResignMain for windowDidBecomeKey and windowDidResignKey, respectively.
This commit is contained in:
Erick Zhao 2019-07-01 10:07:27 -07:00 • committed by Shelley Vohr
parent 3173b66d00
commit c7da54e82a
2 changed files with 30 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/ui/cocoa/atom_ns_window_delegate.mm
View file

@ -88,11 +88,11 @@ using TitleBarStyle = electron::NativeWindowMac::TitleBarStyle;
return frame;
}
- (void)windowDidBecomeMain:(NSNotification*)notification {
- (void)windowDidBecomeKey:(NSNotification*)notification {
shell_->NotifyWindowFocus();
}
- (void)windowDidResignMain:(NSNotification*)notification {
- (void)windowDidResignKey:(NSNotification*)notification {
shell_->NotifyWindowBlur();
}