mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: set prototype names on gin::Constructible classes (#39006)

Browse source 
* fix: set prototype names on gin::Constructible classes

* test: add tests
This commit is contained in:
Shelley Vohr 2023-07-10 11:49:20 +02:00 • committed by GitHub
parent 56b5c00312
commit c7bdd907d7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
23 changed files with 71 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/api/electron_api_notification.cc
View file

@ -256,7 +256,7 @@ bool Notification::IsSupported() {
void Notification::FillObjectTemplate(v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> templ) {
gin::ObjectTemplateBuilder(isolate, "Notification", templ)
gin::ObjectTemplateBuilder(isolate, GetClassName(), templ)
.SetMethod("show", &Notification::Show)
.SetMethod("close", &Notification::Close)
.SetProperty("title", &Notification::GetTitle, &Notification::SetTitle)
@ -282,6 +282,10 @@ void Notification::FillObjectTemplate(v8::Isolate* isolate,
.Build();
}
const char* Notification::GetTypeName() {
return GetClassName();
}
} // namespace electron::api
namespace {