mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

DevTools: remove the 'forced' attribute from the AgentHostClosed in DevToolsAgentHost.

Browse source 
https://chromium-review.googlesource.com/745301
This commit is contained in:
Aleksei Kuzmin 2018-04-11 13:43:06 +02:00 committed by Samuel Attard
parent 4bb3e0da15
commit c75f6f408e
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
atom/browser/api/atom_api_debugger.cc
View file

@ -32,11 +32,8 @@ Debugger::Debugger(v8::Isolate* isolate, content::WebContents* web_contents)
Debugger::~Debugger() {} Debugger::~Debugger() {}
void Debugger::AgentHostClosed(DevToolsAgentHost* agent_host, void Debugger::AgentHostClosed(DevToolsAgentHost* agent_host) {
bool replaced_with_another_client) {
std::string detach_reason = "target closed"; std::string detach_reason = "target closed";
if (replaced_with_another_client)
detach_reason = "replaced with devtools";
Emit("detach", detach_reason); Emit("detach", detach_reason);
} }
@ -110,7 +107,7 @@ void Debugger::Detach() {
if (!agent_host_.get()) if (!agent_host_.get())
return; return;
agent_host_->DetachClient(this); agent_host_->DetachClient(this);
AgentHostClosed(agent_host_.get(), false); AgentHostClosed(agent_host_.get());
agent_host_ = nullptr; agent_host_ = nullptr;
} }

3
atom/browser/api/atom_api_debugger.h
View file

@ -46,8 +46,7 @@ class Debugger : public mate::TrackableObject<Debugger>,
~Debugger() override; ~Debugger() override;
// content::DevToolsAgentHostClient: // content::DevToolsAgentHostClient:
void AgentHostClosed(content::DevToolsAgentHost* agent_host, void AgentHostClosed(content::DevToolsAgentHost* agent_host) override;
bool replaced_with_another_client) override;
void DispatchProtocolMessage(content::DevToolsAgentHost* agent_host, void DispatchProtocolMessage(content::DevToolsAgentHost* agent_host,
const std::string& message) override; const std::string& message) override;