mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove WindowListObserver::OnWindowAdded() (#42979)

Browse source 
refactor: remove WindowListObserver::OnWindowRemove()

these have never been used
This commit is contained in:
Charles Kerr 2024-07-22 03:44:08 -05:00 • committed by GitHub
commit c72a714dd5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/window_list.cc
View file

@ -51,9 +51,6 @@ void WindowList::AddWindow(NativeWindow* window) {
// Push |window| on the appropriate list instance. // Push |window| on the appropriate list instance.
WindowVector& windows = GetInstance()->windows_; WindowVector& windows = GetInstance()->windows_;
windows.push_back(window); windows.push_back(window);
for (WindowListObserver& observer : GetObservers())
observer.OnWindowAdded(window);
} }
// static // static
@ -61,9 +58,6 @@ void WindowList::RemoveWindow(NativeWindow* window) {
WindowVector& windows = GetInstance()->windows_; WindowVector& windows = GetInstance()->windows_;
std::erase(windows, window); std::erase(windows, window);
for (WindowListObserver& observer : GetObservers())
observer.OnWindowRemoved(window);
if (windows.empty()) { if (windows.empty()) {
for (WindowListObserver& observer : GetObservers()) for (WindowListObserver& observer : GetObservers())
observer.OnWindowAllClosed(); observer.OnWindowAllClosed();

6
shell/browser/window_list_observer.h
View file

@ -13,12 +13,6 @@ class NativeWindow;
class WindowListObserver : public base::CheckedObserver { class WindowListObserver : public base::CheckedObserver {
public: public:
// Called immediately after a window is added to the list.
virtual void OnWindowAdded(NativeWindow* window) {}
// Called immediately after a window is removed from the list.
virtual void OnWindowRemoved(NativeWindow* window) {}
// Called when a window close is cancelled by beforeunload handler. // Called when a window close is cancelled by beforeunload handler.
virtual void OnWindowCloseCancelled(NativeWindow* window) {} virtual void OnWindowCloseCancelled(NativeWindow* window) {}