mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

Revert "build: hack around GitHub upload API failure / flake (#16663)" (#16802)

Browse source 
This reverts commit ab503c7e43.
This commit is contained in:
Shelley Vohr 2019-02-06 16:51:45 -08:00 • committed by GitHub
parent c8a1231ad7
commit c6fc5a23fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

35
script/upload-to-github.js
View file

@ -36,28 +36,17 @@ const uploadUrl = `https://uploads.github.com/repos/electron/${targetRepo}/relea
let retry = 0 let retry = 0
function uploadToGitHub () { function uploadToGitHub () {
const fakeFileNamePrefix = `fake-${fileName}-fake-`
const fakeFileName = `${fakeFileNamePrefix}${Date.now()}`
octokit.repos.uploadReleaseAsset({ octokit.repos.uploadReleaseAsset({
url: uploadUrl, url: uploadUrl,
headers: getHeaders(filePath, fileName), headers: getHeaders(filePath, fileName),
file: fs.createReadStream(filePath), file: fs.createReadStream(filePath),
name: fakeFileName name: fileName
}).then((uploadResponse) => { }).then(() => {
console.log(`Successfully uploaded ${fileName} to GitHub as ${fakeFileName}. Going for the rename now.`) console.log(`Successfully uploaded ${fileName} to GitHub.`)
return octokit.repos.updateReleaseAsset({ process.exit()
owner: 'electron',
repo: 'electron',
asset_id: uploadResponse.data.id,
name: fileName
}).then(() => {
console.log(`Successfully renamed ${fakeFileName} to ${fileName}. All done now.`)
process.exit(0)
})
}).catch((err) => { }).catch((err) => {
if (retry < 4) { if (retry < 4) {
console.log(`Error uploading ${fileName} as ${fakeFileName} to GitHub, will retry. Error was:`, err) console.log(`Error uploading ${fileName} to GitHub, will retry. Error was:`, err)
retry++ retry++
octokit.repos.listAssetsForRelease({ octokit.repos.listAssetsForRelease({
@ -67,17 +56,15 @@ function uploadToGitHub () {
}).then(assets => { }).then(assets => {
console.log('Got list of assets for existing release:') console.log('Got list of assets for existing release:')
console.log(JSON.stringify(assets.data, null, ' ')) console.log(JSON.stringify(assets.data, null, ' '))
const existingAssets = assets.data.filter(asset => asset.name.startsWith(fakeFileNamePrefix) || asset.name === fileName) const existingAssets = assets.data.filter(asset => asset.name === fileName)
if (existingAssets.length > 0) { if (existingAssets.length > 0) {
console.log(`${fileName} already exists; will delete before retrying upload.`) console.log(`${fileName} already exists; will delete before retrying upload.`)
Promise.all( octokit.repos.deleteReleaseAsset({
existingAssets.map(existingAsset => octokit.repos.deleteReleaseAsset({ owner: 'electron',
owner: 'electron', repo: targetRepo,
repo: targetRepo, asset_id: existingAssets[0].id
asset_id: existingAsset.id }).catch((deleteErr) => {
}))
).catch((deleteErr) => {
console.log(`Failed to delete existing asset ${fileName}. Error was:`, deleteErr) console.log(`Failed to delete existing asset ${fileName}. Error was:`, deleteErr)
}).then(uploadToGitHub) }).then(uploadToGitHub)
} else { } else {