mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Warning of app not ready in screen module

Browse source
This commit is contained in:
Cheng Zhao 2015-01-14 16:37:48 -08:00
parent e8f1f6819c
commit c6fb645f6b
3 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
atom/browser/api/atom_api_screen.cc
View file

@ -107,15 +107,21 @@ mate::ObjectTemplateBuilder Screen::GetObjectTemplateBuilder(
}
// static
mate::Handle<Screen> Screen::Create(v8::Isolate* isolate) {
v8::Handle<v8::Value> Screen::Create(v8::Isolate* isolate) {
if (!Browser::Get()->is_ready()) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate, "Can not initialize \"screen\" module before app is ready")));
return v8::Undefined(isolate);
}
gfx::Screen* screen = gfx::Screen::GetNativeScreen();
if (!screen) {
isolate->ThrowException(v8::Exception::Error(mate::StringToV8(
isolate, "Failed to get screen information")));
return mate::Handle<Screen>();
return v8::Undefined(isolate);
}
return CreateHandle(isolate, new Screen(screen));
return mate::CreateHandle(isolate, new Screen(screen)).ToV8();
}
} // namespace api